-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
In #15178, we're switching hard-coded constants in tests to insta.
This issue targets updating core tests (datafusion/core).
Examples of tests that need to be switched to insta
let expected = vec![ " {", - has to be smart about that one as it only tests that plan contains some part - you may want to check redactions for that
assert_metrics!( let expected = r#"Projection: Date32("2021-01-09") AS to_timestamp(Utf8("2020-09-08T12:05:00+00:00")) + IntervalDayTime("IntervalDayTime { days: 123, milliseconds: 0 }") let expected_optimized = ["SortPreservingMergeExec: [nullable_col@0 ASC, non_nullable_col@1 ASC]",
... and so on - check quick_test, assert_optimized! DataSourceExec:, assert_optimized_in_all_boundedness_situations
Check the original issue for tips on how to do the switch and examples of completed PRs.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers