Skip to content

Auto run docker containers needed for tests #15092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blaginin opened this issue Mar 8, 2025 · 2 comments
Open

Auto run docker containers needed for tests #15092

blaginin opened this issue Mar 8, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@blaginin
Copy link
Contributor

blaginin commented Mar 8, 2025

Is your feature request related to a problem or challenge?

#13672 adds a new CLI integration testing with external storage tests, using Minio. Currently, running tests requires manually starting a Minio Docker container.

Describe the solution you'd like

@findepi suggests that we can automatically start the required containers

Describe alternatives you've considered

No response

Additional context

@findepi highlighted

In Trino land this is done with testcontainers-java and it works awesomely well from developer experience perspective.

@alamb
Copy link
Contributor

alamb commented Mar 8, 2025

I think @Omega359 did something similar here with sqllogictests for starting postgres:

https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/bin/postgres_container.rs

Perhaps we could use a similar approach for the minio one

@Omega359
Copy link
Contributor

Omega359 commented Mar 9, 2025

I think @Omega359 did something similar here with sqllogictests for starting postgres:

https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/bin/postgres_container.rs

Perhaps we could use a similar approach for the minio one

In my tests I do start minio using the same pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants