You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor range/gen_series signature away from user defined (#18317)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes#123` indicates that this PR will close issue #123.
-->
- Closes#15881
- See my notes below
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
Trying to move away from user defined signatures where possible; mainly
to ensure consistency of error checking/messages. The original issue is
because the function has to do this checking itself leading to
inconsistency of error used (ideally shouldn't be internal). By
uplifting away from a user defined signature we can make use of existing
code meant to handle this checking and error messages for us.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
Defined range/generate_series signature via coercible API instead of
being user defined. Some accompanying changes are needed in the
signature code to make this possible.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Added SLT tests and fixed any existing ones.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No (error messages do change though)
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
0 commit comments