Clippy

Author: friendlymatthew

datafusion/core/src/datasource/physical_plan/arrow_file.rs

@@ -45,6 +45,7 @@ pub struct ArrowSource {
 }
 
 impl ArrowSource {
+    /// Returns a [`ArrowSource`]
     pub fn new(config: FileScanConfig) -> Self {
         Self {
             metrics: Default::default(),

datafusion/datasource-csv/src/source.rs

@@ -71,15 +71,14 @@ use tokio::io::AsyncWriteExt;
 ///     .with_newlines_in_values(true) // The file contains newlines in values;
 ///     .build();
 ///
-/// let source = Arc::new(CsvSource::new(
+/// let source = CsvSource::new(
 ///         true,
 ///         b',',
 ///         b'"',
 ///         config
 ///     )
 ///     .with_terminator(Some(b'#')
-/// ));
-
+/// );
 /// let exec = (DataSourceExec::from_data_source(source));
 /// ```
 #[derive(Clone)]

datafusion/datasource-parquet/src/source.rs

@@ -688,7 +688,7 @@ impl FileSource for ParquetSource {
         filters: Vec<Arc<dyn PhysicalExpr>>,
         config: &ConfigOptions,
     ) -> datafusion_common::Result<FilterPushdownPropagation<Arc<dyn FileSource>>> {
-        let file_schema = self.config.file_schema.clone();
+        let file_schema = Arc::clone(&self.config.file_schema);
 
         // Determine if based on configs we should push filters down.
         // If either the table / scan itself or the config has pushdown enabled,