CI: Warn on unused crates

Author: comphead

.github/actions/setup-rust-runtime/action.yaml

@@ -34,5 +34,5 @@ runs:
         echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV  
         echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV 
         echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
-        echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false -Wunused-crate-dependencies" >> $GITHUB_ENV
+        echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false" >> $GITHUB_ENV
      

datafusion/common/Cargo.toml

@@ -53,7 +53,6 @@ arrow = { workspace = true }
 arrow-array = { workspace = true }
 arrow-buffer = { workspace = true }
 arrow-schema = { workspace = true }
-chrono = { workspace = true }
 half = { workspace = true }
 hashbrown = { workspace = true }
 indexmap = { workspace = true }
@@ -70,4 +69,5 @@ tokio = { workspace = true }
 web-time = "1.1.0"
 
 [dev-dependencies]
+chrono = { workspace = true }
 rand = { workspace = true }

datafusion/core/Cargo.toml

@@ -120,7 +120,6 @@ num-traits = { version = "0.2", optional = true }
 object_store = { workspace = true }
 parking_lot = { workspace = true }
 parquet = { workspace = true, optional = true, default-features = true }
-paste = "1.0.15"
 rand = { workspace = true }
 sqlparser = { workspace = true }
 tempfile = { workspace = true }
@@ -140,17 +139,13 @@ datafusion-functions-window-common = { workspace = true }
 doc-comment = { workspace = true }
 env_logger = { workspace = true }
 paste = "^1.0"
-postgres-protocol = "0.6.4"
-postgres-types = { version = "0.2.4", features = ["derive", "with-chrono-0_4"] }
 rand = { workspace = true, features = ["small_rng"] }
 rand_distr = "0.4.3"
 regex = { workspace = true }
 rstest = { workspace = true }
-rust_decimal = { version = "1.27.0", features = ["tokio-pg"] }
 serde_json = { workspace = true }
 test-utils = { path = "../../test-utils" }
 tokio = { workspace = true, features = ["rt-multi-thread", "parking_lot", "fs"] }
-tokio-postgres = "0.7.7"
 
 [target.'cfg(not(target_os = "windows"))'.dev-dependencies]
 nix = { version = "0.29.0", features = ["fs"] }

datafusion/execution/Cargo.toml

@@ -37,7 +37,6 @@ path = "src/lib.rs"
 
 [dependencies]
 arrow = { workspace = true }
-chrono = { workspace = true }
 dashmap = { workspace = true }
 datafusion-common = { workspace = true, default-features = true }
 datafusion-expr = { workspace = true }
@@ -48,3 +47,6 @@ parking_lot = { workspace = true }
 rand = { workspace = true }
 tempfile = { workspace = true }
 url = { workspace = true }
+
+[dev-dependencies]
+chrono = { workspace = true }

datafusion/expr-common/Cargo.toml

@@ -40,4 +40,6 @@ path = "src/lib.rs"
 arrow = { workspace = true }
 datafusion-common = { workspace = true }
 itertools = { workspace = true }
+
+[dev-dependencies]
 paste = "^1.0"

datafusion/expr/Cargo.toml

@@ -38,10 +38,7 @@ path = "src/lib.rs"
 [features]
 
 [dependencies]
-ahash = { workspace = true }
 arrow = { workspace = true }
-arrow-array = { workspace = true }
-arrow-buffer = { workspace = true }
 chrono = { workspace = true }
 datafusion-common = { workspace = true }
 datafusion-doc = { workspace = true }
@@ -54,9 +51,11 @@ paste = "^1.0"
 recursive = { workspace = true }
 serde_json = { workspace = true }
 sqlparser = { workspace = true }
-strum = { version = "0.26.1", features = ["derive"] }
-strum_macros = "0.26.0"
 
 [dev-dependencies]
+#arrow-array = { workspace = true }
+#arrow-buffer = { workspace = true }
 ctor = { workspace = true }
 env_logger = { workspace = true }
+#strum = { version = "0.26.1", features = ["derive"] }
+#strum_macros = "0.26.0"

datafusion/ffi/Cargo.toml

@@ -42,10 +42,10 @@ async-ffi = { version = "0.5.0", features = ["abi_stable"] }
 async-trait = { workspace = true }
 datafusion = { workspace = true, default-features = false }
 datafusion-proto = { workspace = true }
-doc-comment = { workspace = true }
 futures = { workspace = true }
 log = { workspace = true }
 prost = { workspace = true }
 
 [dev-dependencies]
+doc-comment = { workspace = true }
 tokio = { workspace = true }

datafusion/functions-aggregate-common/Cargo.toml

@@ -42,10 +42,10 @@ arrow = { workspace = true }
 datafusion-common = { workspace = true }
 datafusion-expr-common = { workspace = true }
 datafusion-physical-expr-common = { workspace = true }
-rand = { workspace = true }
 
 [dev-dependencies]
 criterion = "0.5"
+rand = { workspace = true }
 
 [[bench]]
 harness = false

datafusion/functions-nested/Cargo.toml

@@ -54,10 +54,10 @@ datafusion-physical-expr-common = { workspace = true }
 itertools = { workspace = true, features = ["use_std"] }
 log = { workspace = true }
 paste = "1.0.14"
-rand = "0.8.5"
 
 [dev-dependencies]
 criterion = { version = "0.5", features = ["async_tokio"] }
+rand = "0.8.5"
 
 [[bench]]
 harness = false

datafusion/functions-table/Cargo.toml

@@ -38,25 +38,14 @@ path = "src/lib.rs"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-ahash = { workspace = true }
 arrow = { workspace = true }
-arrow-schema = { workspace = true }
 async-trait = { workspace = true }
 datafusion-catalog = { workspace = true }
 datafusion-common = { workspace = true }
-datafusion-execution = { workspace = true }
 datafusion-expr = { workspace = true }
-datafusion-functions-aggregate-common = { workspace = true }
-datafusion-physical-expr = { workspace = true }
-datafusion-physical-expr-common = { workspace = true }
 datafusion-physical-plan = { workspace = true }
-half = { workspace = true }
-indexmap = { workspace = true }
-log = { workspace = true }
 parking_lot = { workspace = true }
 paste = "1.0.14"
 
 [dev-dependencies]
 arrow = { workspace = true, features = ["test_utils"] }
-criterion = "0.5"
-rand = { workspace = true }

datafusion/macros/Cargo.toml

@@ -37,6 +37,5 @@ path = "src/user_doc.rs"
 proc-macro = true
 
 [dependencies]
-proc-macro2 = "1.0"
 quote = "1.0.37"
 syn = { version = "2.0.79", features = ["full"] }

datafusion/optimizer/Cargo.toml

@@ -37,7 +37,6 @@ path = "src/lib.rs"
 
 [dependencies]
 arrow = { workspace = true }
-async-trait = { workspace = true }
 chrono = { workspace = true }
 datafusion-common = { workspace = true, default-features = true }
 datafusion-expr = { workspace = true }
@@ -50,6 +49,7 @@ regex = { workspace = true }
 regex-syntax = "0.8.0"
 
 [dev-dependencies]
+async-trait = { workspace = true }
 ctor = { workspace = true }
 datafusion-functions-aggregate = { workspace = true }
 datafusion-functions-window-common = { workspace = true }

datafusion/physical-plan/Cargo.toml

@@ -60,16 +60,16 @@ hashbrown = { workspace = true }
 indexmap = { workspace = true }
 itertools = { workspace = true, features = ["use_std"] }
 log = { workspace = true }
-once_cell = "1.18.0"
 parking_lot = { workspace = true }
 pin-project-lite = "^0.2.7"
-rand = { workspace = true }
 tokio = { workspace = true }
 
 [dev-dependencies]
 criterion = { version = "0.5", features = ["async_futures"] }
 datafusion-functions-aggregate = { workspace = true }
 datafusion-functions-window = { workspace = true }
+once_cell = "1.18.0"
+rand = { workspace = true }
 rstest = { workspace = true }
 rstest_reuse = "0.7.0"
 tokio = { workspace = true, features = [

datafusion/proto-common/Cargo.toml

@@ -41,14 +41,10 @@ json = ["serde", "serde_json", "pbjson"]
 
 [dependencies]
 arrow = { workspace = true }
-chrono = { workspace = true }
 datafusion-common = { workspace = true }
-object_store = { workspace = true }
 pbjson = { workspace = true, optional = true }
 prost = { workspace = true }
 serde = { version = "1.0", optional = true }
 serde_json = { workspace = true, optional = true }
 
 [dev-dependencies]
-doc-comment = { workspace = true }
-tokio = { workspace = true }

datafusion/wasmtest/Cargo.toml

@@ -34,9 +34,6 @@ workspace = true
 crate-type = ["cdylib", "rlib"]
 
 [dependencies]
-# chrono must be compiled with wasmbind feature
-chrono = { version = "0.4", features = ["wasmbind"] }
-
 # The `console_error_panic_hook` crate provides better debugging of panics by
 # logging them with `console.error`. This is great for development, but requires
 # all the `std::fmt` and `std::panicking` infrastructure, so isn't great for
@@ -48,16 +45,11 @@ datafusion-common = { workspace = true, default-features = true }
 datafusion-execution = { workspace = true }
 datafusion-expr = { workspace = true }
 datafusion-optimizer = { workspace = true, default-features = true }
-datafusion-physical-expr = { workspace = true, default-features = true }
 datafusion-physical-plan = { workspace = true }
 datafusion-sql = { workspace = true }
 
 # getrandom must be compiled with js feature
-getrandom = { version = "0.2.8", features = ["js"] }
-
-parquet = { workspace = true }
 wasm-bindgen = "0.2.87"
-wasm-bindgen-futures = "0.4.40"
 
 [dev-dependencies]
 tokio = { workspace = true }

test-utils/Cargo.toml

@@ -30,5 +30,4 @@ arrow = { workspace = true }
 chrono-tz = { version = "0.10.0", default-features = false }
 datafusion-common = { workspace = true, default-features = true }
 env_logger = { workspace = true }
-paste = "1.0.15"
 rand = { workspace = true }