Skip to content

Commit 04b6d4d

Browse files
authored
Fix combine with session config (#14139)
* fix combine with session config * must use it
1 parent d42b994 commit 04b6d4d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

datafusion/common/src/config.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1365,8 +1365,7 @@ impl TableOptions {
13651365
/// A new `TableOptions` instance with settings applied from the session config.
13661366
pub fn default_from_session_config(config: &ConfigOptions) -> Self {
13671367
let initial = TableOptions::default();
1368-
initial.combine_with_session_config(config);
1369-
initial
1368+
initial.combine_with_session_config(config)
13701369
}
13711370

13721371
/// Updates the current `TableOptions` with settings from a given session config.
@@ -1378,6 +1377,7 @@ impl TableOptions {
13781377
/// # Returns
13791378
///
13801379
/// A new `TableOptions` instance with updated settings from the session config.
1380+
#[must_use = "this method returns a new instance"]
13811381
pub fn combine_with_session_config(&self, config: &ConfigOptions) -> Self {
13821382
let mut clone = self.clone();
13831383
clone.parquet.global = config.execution.parquet.clone();

0 commit comments

Comments
 (0)