don't create indexes for old lucene versions

Author: rnewson

nouveau/src/main/java/org/apache/couchdb/nouveau/core/IndexManager.java

@@ -40,11 +40,13 @@
 import org.apache.lucene.analysis.Analyzer;
 import org.apache.lucene.index.IndexWriter;
 import org.apache.lucene.index.IndexWriterConfig;
+import org.apache.lucene.index.IndexWriterConfig.OpenMode;
 import org.apache.lucene.misc.store.DirectIODirectory;
 import org.apache.lucene.search.SearcherFactory;
 import org.apache.lucene.search.SearcherManager;
 import org.apache.lucene.store.Directory;
 import org.apache.lucene.store.FSDirectory;
+import org.apache.lucene.util.Version;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -219,6 +221,12 @@ public void create(final String name, IndexDefinition indexDefinition) throws IO
             assertSame(indexDefinition, loadIndexDefinition(name));
             return;
         }
+        if (indexDefinition.getLuceneVersion() != Version.LATEST.major) {
+            var msg = String.format(
+                    "cannot create index of version %d, only %d supported",
+                    indexDefinition.getLuceneVersion(), Version.LATEST.major);
+            throw new WebApplicationException(msg, Status.FORBIDDEN);
+        }
 
         final Lock lock = this.createLock.writeLock(name);
         lock.lock();
@@ -383,6 +391,9 @@ private Index load(final String name) throws IOException {
         final Directory dir = new DirectIODirectory(
                 FSDirectory.open(path.resolve(Integer.toString(indexDefinition.getLuceneVersion()))));
         final IndexWriterConfig config = new IndexWriterConfig(analyzer);
+        if (indexDefinition.getLuceneVersion() != Version.LATEST.major) {
+            config.setOpenMode(OpenMode.APPEND);
+        }
         config.setUseCompoundFile(false);
         final IndexWriter writer = new IndexWriter(dir, config);
         final long updateSeq = getSeq(writer, "update_seq");

nouveau/src/test/java/org/apache/couchdb/nouveau/core/IndexManagerTest.java

@@ -24,6 +24,7 @@
 import org.apache.couchdb.nouveau.api.IndexDefinition;
 import org.apache.couchdb.nouveau.api.SearchRequest;
 import org.apache.couchdb.nouveau.lucene.ParallelSearcherFactory;
+import org.apache.lucene.util.Version;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
@@ -56,7 +57,7 @@ public static void cleanup() throws Exception {
 
     @Test
     public void managerReturnsUsableIndex() throws Exception {
-        final IndexDefinition indexDefinition = new IndexDefinition();
+        final IndexDefinition indexDefinition = new IndexDefinition(Version.LATEST.major, "standard", null);
         indexDefinition.setDefaultAnalyzer("standard");
         manager.create("foo", indexDefinition);
         var searchRequest = new SearchRequest();
@@ -67,7 +68,7 @@ public void managerReturnsUsableIndex() throws Exception {
 
     @Test
     public void managerReopensAClosedIndex() throws Exception {
-        final IndexDefinition indexDefinition = new IndexDefinition();
+        final IndexDefinition indexDefinition = new IndexDefinition(Version.LATEST.major, "standard", null);
         indexDefinition.setDefaultAnalyzer("standard");
 
         manager.create("bar", indexDefinition);

nouveau/src/test/java/org/apache/couchdb/nouveau/lucene/LuceneIndexTest.java

@@ -42,13 +42,14 @@
 import org.apache.lucene.search.SearcherManager;
 import org.apache.lucene.store.Directory;
 import org.apache.lucene.store.FSDirectory;
+import org.apache.lucene.util.Version;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
 public class LuceneIndexTest {
 
     protected final Index setup(final Path path) throws IOException {
-        final IndexDefinition indexDefinition = new IndexDefinition();
+        final IndexDefinition indexDefinition = new IndexDefinition(Version.LATEST.major, "standard", null);
         indexDefinition.setDefaultAnalyzer("standard");
         final Analyzer analyzer = LuceneAnalyzerFactory.fromDefinition(indexDefinition);
         final Directory dir = new DirectIODirectory(FSDirectory.open(path));

src/nouveau/src/nouveau_api.erl

@@ -234,6 +234,8 @@ search_path(#index{} = Index) ->
 
 jaxrs_error(400, Body) ->
     {bad_request, message(Body)};
+jaxrs_error(403, Body) ->
+    {forbidden, message(Body)};
 jaxrs_error(404, Body) ->
     {not_found, message(Body)};
 jaxrs_error(405, Body) ->