This repository was archived by the owner on Jan 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 171
Troubles with template/Properties/Default.rd.xml #288
Copy link
Copy link
Closed
Milestone
Description
Continuation of apache/cordova-discuss#106 which is now closed:
cordova-windows has suffered from the following issues with template/Properties/Default.rd.xml that was introduced in GH-228 (CB-12499):
- CB-13834 - problem building with build with params
--release --bundle --archs="x64 x86 arm"on AppVeyor CI which remains unsolved CB-14224 - running(already solved in CB-14224 Default.rd.xml header fixes #284 [master] and CB-14224 Default.rd.xml updates (6.0.x patch) #285 [6.0.x patch])coho audit-license-headers -r windowsgives a message thattemplate/Properties/Default.rd.xmlis missing the license headerCB-14225 - misspelling in sample Namespace serialize attribute name (with solution in CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml #286)
It is clear from CB-12499 that Default.rd.xml was introduced to solve a problem but it is unfortunately the actual circumstances are not so clear to me. The following observations indicate to me that Default.rd.xml should only be needed in case of a project using C# which I think is not always the case:
- If I would try generating both a JavaScript UWP project and a C# UWP project then VS 2017 would only add
Properties/Default.rd.xmlin case of C#. - Microsoft / Windows-universal-samples keeps its sample
Default.rd.xmlin acsdirectory (Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml
Given the observed troubles and what I think are limited circumstances of need I would like to propose that we remove template/Properties/Default.rd.xml at some point in the future, as a major release item, and support it in a plugin if needed.
Metadata
Metadata
Assignees
Labels
No labels