Skip to content

Commit 2e66ca9

Browse files
committed
feat: upgrade minimatch dependency to 10.2.1 (#545)
1 parent d086457 commit 2e66ca9

File tree

5 files changed

+40
-58
lines changed

5 files changed

+40
-58
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@
4444
"semantic-release": "^17.4.4",
4545
"ts-jest": "^26.5.3",
4646
"tslint": "^5.11.0",
47-
"typescript": "^3.7.2"
47+
"typescript": "^4.9.5"
4848
},
4949
"dependencies": {
5050
"@casbin/expression-eval": "^5.3.0",
5151
"await-lock": "^2.0.1",
5252
"buffer": "^6.0.3",
5353
"csv-parse": "^5.5.6",
54-
"minimatch": "^7.4.2"
54+
"minimatch": "^10.2.1"
5555
},
5656
"files": [
5757
"lib",

src/internalEnforcer.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export class InternalEnforcer extends CoreEnforcer {
3434
try {
3535
await this.adapter.addPolicy(sec, ptype, rule);
3636
} catch (e) {
37-
if (e.message !== 'not implemented') {
37+
if (e instanceof Error && e.message !== 'not implemented') {
3838
throw e;
3939
}
4040
}
@@ -74,7 +74,7 @@ export class InternalEnforcer extends CoreEnforcer {
7474
try {
7575
await this.adapter.addPolicies(sec, ptype, rules);
7676
} catch (e) {
77-
if (e.message !== 'not implemented') {
77+
if (e instanceof Error && e.message !== 'not implemented') {
7878
throw e;
7979
}
8080
}
@@ -121,7 +121,7 @@ export class InternalEnforcer extends CoreEnforcer {
121121
try {
122122
await this.adapter.addPolicies(sec, ptype, newRules);
123123
} catch (e) {
124-
if (e.message !== 'not implemented') {
124+
if (e instanceof Error && e.message !== 'not implemented') {
125125
throw e;
126126
}
127127
}
@@ -167,7 +167,7 @@ export class InternalEnforcer extends CoreEnforcer {
167167
try {
168168
await this.adapter.updatePolicy(sec, ptype, oldRule, newRule);
169169
} catch (e) {
170-
if (e.message !== 'not implemented') {
170+
if (e instanceof Error && e.message !== 'not implemented') {
171171
throw e;
172172
}
173173
}
@@ -208,7 +208,7 @@ export class InternalEnforcer extends CoreEnforcer {
208208
try {
209209
await this.adapter.removePolicy(sec, ptype, rule);
210210
} catch (e) {
211-
if (e.message !== 'not implemented') {
211+
if (e instanceof Error && e.message !== 'not implemented') {
212212
throw e;
213213
}
214214
}
@@ -246,7 +246,7 @@ export class InternalEnforcer extends CoreEnforcer {
246246
try {
247247
await this.adapter.removePolicies(sec, ptype, rules);
248248
} catch (e) {
249-
if (e.message !== 'not implemented') {
249+
if (e instanceof Error && e.message !== 'not implemented') {
250250
throw e;
251251
}
252252
}
@@ -288,7 +288,7 @@ export class InternalEnforcer extends CoreEnforcer {
288288
try {
289289
await this.adapter.removeFilteredPolicy(sec, ptype, fieldIndex, ...fieldValues);
290290
} catch (e) {
291-
if (e.message !== 'not implemented') {
291+
if (e instanceof Error && e.message !== 'not implemented') {
292292
throw e;
293293
}
294294
}

src/util/util.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,22 +90,22 @@ function setEquals(a: string[], b: string[]): boolean {
9090
}
9191

9292
// readFile return a promise for readFile.
93-
function readFile(path: string, encoding?: string): any {
93+
function readFile(path: string, encoding?: string): Promise<string> {
9494
const fs = mustGetDefaultFileSystem();
95-
return new Promise((resolve, reject) => {
95+
return new Promise<string>((resolve, reject) => {
9696
try {
97-
fs.readFileSync(path, encoding || 'utf8');
98-
resolve();
97+
const content = fs.readFileSync(path, encoding || 'utf8') as string;
98+
resolve(content);
9999
} catch (e) {
100100
reject(e);
101101
}
102102
});
103103
}
104104

105105
// writeFile return a promise for writeFile.
106-
function writeFile(path: string, file: string, encoding?: string): any {
106+
function writeFile(path: string, file: string, encoding?: string): Promise<void> {
107107
const fs = mustGetDefaultFileSystem();
108-
return new Promise((resolve, reject) => {
108+
return new Promise<void>((resolve, reject) => {
109109
try {
110110
fs.writeFileSync(path, file, encoding || 'utf-8');
111111
resolve();

test/model/model.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,9 @@ test('TestLoadModelFromConfig', (done) => {
6565
}
6666

6767
if (e instanceof Error) {
68+
const error = e;
6869
requiredSections.forEach((n) => {
69-
if (!e.message.includes(n)) {
70+
if (!error.message.includes(n)) {
7071
throw new Error(`section name: ${sectionNameMap[n]} should be in message`);
7172
}
7273
});

yarn.lock

Lines changed: 23 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -815,16 +815,6 @@
815815
dependencies:
816816
any-observable "^0.3.0"
817817

818-
"@semantic-release/changelog@^5.0.1":
819-
version "5.0.1"
820-
resolved "https://registry.npmjs.org/@semantic-release/changelog/-/changelog-5.0.1.tgz#50a84b63e5d391b7debfe021421589fa2bcdafe4"
821-
integrity sha512-unvqHo5jk4dvAf2nZ3aw4imrlwQ2I50eVVvq9D47Qc3R+keNqepx1vDYwkjF8guFXnOYaYcR28yrZWno1hFbiw==
822-
dependencies:
823-
"@semantic-release/error" "^2.1.0"
824-
aggregate-error "^3.0.0"
825-
fs-extra "^9.0.0"
826-
lodash "^4.17.4"
827-
828818
"@semantic-release/commit-analyzer@^8.0.0", "@semantic-release/commit-analyzer@^8.0.1":
829819
version "8.0.1"
830820
resolved "https://registry.npmjs.org/@semantic-release/commit-analyzer/-/commit-analyzer-8.0.1.tgz#5d2a37cd5a3312da0e3ac05b1ca348bf60b90bca"
@@ -838,25 +828,11 @@
838828
lodash "^4.17.4"
839829
micromatch "^4.0.2"
840830

841-
"@semantic-release/error@^2.1.0", "@semantic-release/error@^2.2.0":
831+
"@semantic-release/error@^2.2.0":
842832
version "2.2.0"
843833
resolved "https://registry.npmjs.org/@semantic-release/error/-/error-2.2.0.tgz#ee9d5a09c9969eade1ec864776aeda5c5cddbbf0"
844834
integrity sha512-9Tj/qn+y2j+sjCI3Jd+qseGtHjOAeg7dU2/lVcqIQ9TV3QDaDXDYXcoOHU+7o2Hwh8L8ymL4gfuO7KxDs3q2zg==
845835

846-
"@semantic-release/git@^9.0.0":
847-
version "9.0.0"
848-
resolved "https://registry.npmjs.org/@semantic-release/git/-/git-9.0.0.tgz#304c4883c87d095b1faaae93300f1f1e0466e9a5"
849-
integrity sha512-AZ4Zha5NAPAciIJH3ipzw/WU9qLAn8ENaoVAhD6srRPxTpTzuV3NhNh14rcAo8Paj9dO+5u4rTKcpetOBluYVw==
850-
dependencies:
851-
"@semantic-release/error" "^2.1.0"
852-
aggregate-error "^3.0.0"
853-
debug "^4.0.0"
854-
dir-glob "^3.0.0"
855-
execa "^4.0.0"
856-
lodash "^4.17.4"
857-
micromatch "^4.0.0"
858-
p-reduce "^2.0.0"
859-
860836
"@semantic-release/github@^7.0.0":
861837
version "7.2.1"
862838
resolved "https://registry.npmjs.org/@semantic-release/github/-/github-7.2.1.tgz#e833245746413e0830b65112331ca0a00b35cf95"
@@ -1586,6 +1562,11 @@ balanced-match@^1.0.0:
15861562
resolved "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.2.tgz#e83e3a7e3f300b34cb9d87f615fa0cbf357690ee"
15871563
integrity sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw==
15881564

1565+
balanced-match@^4.0.2:
1566+
version "4.0.3"
1567+
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-4.0.3.tgz#6337a2f23e0604a30481423432f99eac603599f9"
1568+
integrity sha512-1pHv8LX9CpKut1Zp4EXey7Z8OfH11ONNH6Dhi2WDUt31VVZFXZzKwXcysBgqSumFCmR+0dqjMK5v5JiFHzi0+g==
1569+
15891570
base64-js@^1.3.1:
15901571
version "1.5.1"
15911572
resolved "https://registry.yarnpkg.com/base64-js/-/base64-js-1.5.1.tgz#1b1b440160a5bf7ad40b650f095963481903930a"
@@ -1646,12 +1627,12 @@ brace-expansion@^1.1.7:
16461627
balanced-match "^1.0.0"
16471628
concat-map "0.0.1"
16481629

1649-
brace-expansion@^2.0.1:
1650-
version "2.0.1"
1651-
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-2.0.1.tgz#1edc459e0f0c548486ecf9fc99f2221364b9a0ae"
1652-
integrity sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==
1630+
brace-expansion@^5.0.2:
1631+
version "5.0.2"
1632+
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-5.0.2.tgz#b6c16d0791087af6c2bc463f52a8142046c06b6f"
1633+
integrity sha512-Pdk8c9poy+YhOgVWw1JNN22/HcivgKWwpxKq04M/jTmHyCZn12WPJebZxdjSa5TmBqISrUSgNYU3eRORljfCCw==
16531634
dependencies:
1654-
balanced-match "^1.0.0"
1635+
balanced-match "^4.0.2"
16551636

16561637
braces@^2.3.1:
16571638
version "2.3.2"
@@ -5230,7 +5211,7 @@ micromatch@^3.0.4, micromatch@^3.1.4, micromatch@^3.1.8:
52305211
snapdragon "^0.8.1"
52315212
to-regex "^3.0.2"
52325213

5233-
micromatch@^4.0.0, micromatch@^4.0.2:
5214+
micromatch@^4.0.2:
52345215
version "4.0.4"
52355216
resolved "https://registry.npmjs.org/micromatch/-/micromatch-4.0.4.tgz#896d519dfe9db25fce94ceb7a500919bf881ebf9"
52365217
integrity sha512-pRmzw/XUcwXGpD9aI9q/0XOwLNygjETJ8y0ao0wdqprrzDa4YnxLcz7fQRZr8voh8V10kGhABbNcHVk5wHgWwg==
@@ -5270,20 +5251,20 @@ min-indent@^1.0.0:
52705251
resolved "https://registry.npmjs.org/min-indent/-/min-indent-1.0.1.tgz#a63f681673b30571fbe8bc25686ae746eefa9869"
52715252
integrity sha512-I9jwMn07Sy/IwOj3zVkVik2JTvgpaykDZEigL6Rx6N9LbMywwUSMtxET+7lVoDLLd3O3IXwJwvuuns8UB/HeAg==
52725253

5254+
minimatch@^10.2.1:
5255+
version "10.2.1"
5256+
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-10.2.1.tgz#9d82835834cdc85d5084dd055e9a4685fa56e5f0"
5257+
integrity sha512-MClCe8IL5nRRmawL6ib/eT4oLyeKMGCghibcDWK+J0hh0Q8kqSdia6BvbRMVk6mPa6WqUa5uR2oxt6C5jd533A==
5258+
dependencies:
5259+
brace-expansion "^5.0.2"
5260+
52735261
minimatch@^3.0.4:
52745262
version "3.0.4"
52755263
resolved "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz#5166e286457f03306064be5497e8dbb0c3d32083"
52765264
integrity sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==
52775265
dependencies:
52785266
brace-expansion "^1.1.7"
52795267

5280-
minimatch@^7.4.2:
5281-
version "7.4.2"
5282-
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-7.4.2.tgz#157e847d79ca671054253b840656720cb733f10f"
5283-
integrity sha512-xy4q7wou3vUoC9k1xGTXc+awNdGaGVHtFUaey8tiX4H1QRc04DZ/rmDFwNm2EBsuYEhAZ6SgMmYf3InGY6OauA==
5284-
dependencies:
5285-
brace-expansion "^2.0.1"
5286-
52875268
minimist-options@4.1.0:
52885269
version "4.1.0"
52895270
resolved "https://registry.npmjs.org/minimist-options/-/minimist-options-4.1.0.tgz#c0655713c53a8a2ebd77ffa247d342c40f010619"
@@ -7609,10 +7590,10 @@ typedarray-to-buffer@^3.1.5:
76097590
dependencies:
76107591
is-typedarray "^1.0.0"
76117592

7612-
typescript@^3.7.2:
7613-
version "3.9.9"
7614-
resolved "https://registry.npmjs.org/typescript/-/typescript-3.9.9.tgz#e69905c54bc0681d0518bd4d587cc6f2d0b1a674"
7615-
integrity sha512-kdMjTiekY+z/ubJCATUPlRDl39vXYiMV9iyeMuEuXZh2we6zz80uovNN2WlAxmmdE/Z/YQe+EbOEXB5RHEED3w==
7593+
typescript@^4.9.5:
7594+
version "4.9.5"
7595+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz#095979f9bcc0d09da324d58d03ce8f8374cbe65a"
7596+
integrity sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==
76167597

76177598
uglify-js@^3.1.4:
76187599
version "3.13.5"

0 commit comments

Comments
 (0)