Skip to content

[DO NOT MERGE] Unpin cibuildwheel#37504

Draft
jrmccluskey wants to merge 1 commit intoapache:masterfrom
jrmccluskey:cibuildwheelExperiment
Draft

[DO NOT MERGE] Unpin cibuildwheel#37504
jrmccluskey wants to merge 1 commit intoapache:masterfrom
jrmccluskey:cibuildwheelExperiment

Conversation

@jrmccluskey
Copy link
Contributor

cibuildwheel >= 3 requires Python 3.11+ to run, but must also be upgraded beyond this bound for Python 3.14 support. For the build wheels action this isn't a big deal, running under Python 3.11 is a trivial change; however, bdistPy310 breaks if you change the cibuildwheel version. This PR is an experiment to see if unpinning is viable, or if a slight rewrite to conditionally pin is necessary.

DO NOT MERGE


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request explores the impact of unpinning the cibuildwheel dependency in the Python SDK build process. The primary motivation is to enable compatibility with newer Python versions (3.11+ and 3.14) which are required by recent cibuildwheel releases. This is an experimental change to assess potential side effects, especially concerning the bdistPy310 build, before a permanent solution is implemented.

Highlights

  • Dependency Unpinning: The cibuildwheel dependency has been unpinned from version 2.23.3 in sdks/python/build.gradle. This change allows the build process to use the latest available version of cibuildwheel.
  • Python Version Compatibility: This change is an experiment to address compatibility issues, as cibuildwheel version 3 and above requires Python 3.11+ and is necessary for Python 3.14 support. The current pinned version is incompatible with these newer Python environments.
  • Experimental Change: This pull request is explicitly marked as 'DO NOT MERGE' and serves as an experiment to evaluate the viability of unpinning cibuildwheel. The author is investigating whether a direct unpin is feasible or if a more complex conditional pinning strategy will be required, particularly due to potential breakage with bdistPy310.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/build.gradle
    • Removed the explicit version pin ==2.23.3 for cibuildwheel in the pip install command, allowing the build to use the latest available version.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build_wheels.yml
Activity
  • The pull request was opened by jrmccluskey.
  • The title and description clearly indicate that this is an experimental change and is not ready for merging, marked with '[DO NOT MERGE]'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant