Skip to content

Conversation

@acrites
Copy link
Contributor

@acrites acrites commented Jan 21, 2026

Adds a new SchemaCoderPayload proto to use for portable SchemaCoders.

This new payload is currently not used. In the future, each SDK can use this proto instead of a custom coder blob to represent SchemaCoder objects. This will allow the runners to interpret the underlying Schema to do things like compatibility checks and encoding position reorderings.

Addresses #31686 and many others.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @acrites, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new SchemaCoderPayload Protocol Buffer message and registers a corresponding SCHEMA coder type in the Beam Runner API. The primary goal is to establish a standardized, portable representation for SchemaCoder objects across different SDKs. While not immediately utilized, this infrastructure will enable Beam runners to interpret underlying schemas, facilitating future enhancements such as compatibility validation and optimized encoding strategies for data processing.

Highlights

  • New Schema Coder Type: Introduced a new SCHEMA coder type (value 18) within the StandardCoders enum in beam_runner_api.proto, specifically for arbitrary types convertible to and from row objects.
  • SchemaCoderPayload Definition: Defined a new SchemaCoderPayload message in schema.proto to encapsulate information required for SCHEMA type coders. This payload includes the schema itself, functions to convert to_row_fn and from_row_fn, and additional_coder_infos.
  • Future-proofing Schema Coders: This change is a foundational step, not yet actively used, to allow SDKs to represent SchemaCoder objects using a standardized proto, enabling advanced runner capabilities like compatibility checks and encoding reorderings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the model label Jan 21, 2026
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @Abacn added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@acrites
Copy link
Contributor Author

acrites commented Jan 22, 2026

@kennknowles since this is the proto we were talking about.

@kennknowles kennknowles self-requested a review January 23, 2026 16:04
@kennknowles kennknowles merged commit e12436a into apache:master Jan 26, 2026
117 of 119 checks passed
FunctionSpec to_row_fn = 2;

// Function mapping from Row type to underlying object.
FunctionSpec from_row_fn = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the expectation that this function spec is only understandable by a given SDK. If so I have a couple of questions.

(1) How can one (a runner for example) identify the correct SDK given the coder ? Should we also attach the environment ID to the coder ? (I don't think just URL in the function spec is adequate).

(2) Does this mean that this coder is not truly portable ? For example, cannot be used in a cross-language boundary ? To make it truly portable, we might need a list of FunctionSpecs with entries for multiple environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants