Skip to content

Conversation

@claudevdm
Copy link
Collaborator

This maps Generic record ARRAY and beam row array<Timestamp.NANOS> properly to REPEATED TIMESTAMP(12) proto table schema so that writing nanosecond precision arrays work.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Collaborator Author

/gemini review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam BigQuery Storage API connector by introducing support for writing arrays of nanosecond-precision timestamps. It addresses a limitation where the timestamp precision for elements within an array was not correctly propagated during schema conversion from Avro GenericRecords and Beam Rows to BigQuery's proto table schema. The changes ensure that high-precision timestamp arrays are accurately represented and stored in BigQuery.

Highlights

  • Timestamp Precision Propagation: Implemented logic to correctly propagate timestampPrecision for array elements when converting Avro GenericRecords and Beam Rows to BigQuery Storage API proto schemas. This ensures that the precision of nanosecond timestamps within arrays is preserved.
  • Support for Repeated Nanosecond Timestamps: Enabled proper mapping of ARRAY<timestamp-nanos> from Avro GenericRecords and array<Timestamp.NANOS> from Beam Rows to REPEATED TIMESTAMP(12) in the BigQuery proto table schema.
  • New Test Cases: Added comprehensive unit tests in AvroGenericRecordToStorageApiProtoTest and BeamRowToStorageApiProtoTest to validate the correct handling and schema conversion of repeated nanosecond precision timestamps.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claudevdm claudevdm requested a review from damccorm January 13, 2026 18:22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for picosecond precision timestamps within arrays when converting from Avro GenericRecord and Beam Row to BigQuery Storage API protos. The changes correctly propagate the timestamp precision from the array element type to the repeated field schema. The accompanying tests validate this new functionality. My feedback includes a minor suggestion to improve code consistency.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claudevdm claudevdm merged commit aad5864 into apache:master Jan 14, 2026
15 checks passed
claudevdm added a commit to claudevdm/beam that referenced this pull request Jan 14, 2026
claudevdm added a commit that referenced this pull request Jan 14, 2026
* Map TIMSETAMP(12) BQ type -> timestamp-nanos Avro type in default schemafactory (#37257)

* Map TIMSETAMP(12) BQ type -> timestamp-nanos Avro type in default schemafactory

* Use default schemafactory in test.

---------

Co-authored-by: Claude <[email protected]>

* Support picosecond tiemstamps when writing GenericRecord and Beam Rows. (#37294)

Co-authored-by: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants