-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Support picosecond tiemstamps when writing GenericRecord and Beam Rows. #37294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gemini review |
Summary of ChangesHello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Apache Beam BigQuery Storage API connector by introducing support for writing arrays of nanosecond-precision timestamps. It addresses a limitation where the timestamp precision for elements within an array was not correctly propagated during schema conversion from Avro GenericRecords and Beam Rows to BigQuery's proto table schema. The changes ensure that high-precision timestamp arrays are accurately represented and stored in BigQuery. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for picosecond precision timestamps within arrays when converting from Avro GenericRecord and Beam Row to BigQuery Storage API protos. The changes correctly propagate the timestamp precision from the array element type to the repeated field schema. The accompanying tests validate this new functionality. My feedback includes a minor suggestion to improve code consistency.
...rm/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java
Show resolved
Hide resolved
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…s. (apache#37294) Co-authored-by: Claude <[email protected]>
* Map TIMSETAMP(12) BQ type -> timestamp-nanos Avro type in default schemafactory (#37257) * Map TIMSETAMP(12) BQ type -> timestamp-nanos Avro type in default schemafactory * Use default schemafactory in test. --------- Co-authored-by: Claude <[email protected]> * Support picosecond tiemstamps when writing GenericRecord and Beam Rows. (#37294) Co-authored-by: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
This maps Generic record ARRAY and beam row array<Timestamp.NANOS> properly to REPEATED TIMESTAMP(12) proto table schema so that writing nanosecond precision arrays work.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.