Iceberg fileio close

[ahmedabu98]

Keep FileIO open for writer lifetime to avoid connection pool shutdown issues Add test to verify FileIO remains open until writer close

Fixes #36438

Copied over from #36601

[gemini-code-assist]

Summary of Changes

Hello @ahmedabu98, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the Iceberg RecordWriter where FileIO instances were being closed too early, leading to connection pool shutdown errors. The fix ensures that FileIO resources are managed correctly throughout the writer's lifecycle, preventing premature resource release and enhancing the stability of data writing operations. The changes are validated by a new dedicated test case.

Highlights

• FileIO Lifecycle Management: The FileIO instance within the RecordWriter is now kept open for the entire lifetime of the writer, rather than being closed prematurely. This change addresses connection pool shutdown issues, specifically 'Connection pool shut down' errors (Issue [Bug]: IcebergIO Connection pool shut down error when writing to S3 with Glue catalog due to premature FileIO closure #36438).
• Robust Closure Handling: The close() method in RecordWriter has been refactored to explicitly close the FileIO instance in a finally block. It also includes improved error handling, allowing for multiple exceptions to be suppressed if both the writer and FileIO closure fail.
• New Test Case: A new test, testRecordWriterKeepsFileIOOpenUntilClose, has been added to RecordWriterManagerTest to verify that the FileIO remains open during the writer's operation and is correctly closed only when the writer itself is closed. This test uses custom CloseTrackingFileIO and CloseAwareOutputFile classes to monitor the FileIO's state.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).