Deduplicate MonitoringInfo in PortableMetrics

[Suvrat1629]

Please add a meaningful description for your change here

---

fixes #32001
Merge attempted and committed MonitoringInfo by metric identity, prefer committed entries, and create MetricResult with the correct committed flag.
Add unit test verifying deduplication and that the committed value wins .

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @Suvrat1629, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in PortableMetrics where attempted and committed metric entries could lead to redundant or ambiguous metric reporting. By introducing a robust deduplication strategy, the system now ensures that for any given metric identity, only a single, authoritative MonitoringInfo is retained, with a clear preference for committed values. This enhances the accuracy and clarity of metric results within the Apache Beam portable runner.

Highlights

• Metric Deduplication: Implemented a mechanism to deduplicate MonitoringInfo entries in PortableMetrics, resolving potential redundancy between attempted and committed metrics.
• Committed Value Preference: When both attempted and committed metrics exist for the same identity, the committed value is prioritized and used, ensuring data accuracy.
• Correct Committed Flag: MetricResult objects are now created with the accurate isCommitted flag, reflecting the true status of the metric.
• New Unit Test: A dedicated unit test was added to confirm the deduplication logic and the preference for committed metric values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Suvrat1629]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly addresses the deduplication of attempted and committed metrics, ensuring that committed metrics take precedence. A new test case validates this behavior. However, the implementation introduces a performance issue in how it processes the merged metrics list. My review includes suggestions to refactor several methods to improve efficiency from O(N^2) to O(N) by avoiding redundant lookups. This change will also simplify the code by allowing the removal of a helper method.

[github-actions]

Assigning reviewers:

R: @kennknowles added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[github-actions]

Reminder, please take a look at this pr: @kennknowles

[ahmedabu98]

friendly ping to review @kennknowles
cc @Abacn (saw you opened the original bug #32001)

[Abacn]

Thanks. The solution looks good. Just had one comment

[Abacn]

waiting on author

[Abacn]

Thank you!