-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) #36834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sjvanrossum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the KafkaIO connector by upgrading the minimum supported Kafka client version and refactoring how end offsets are retrieved. By switching from the Consumer client to the more efficient Admin client for offset requests, the change significantly improves memory performance and reintroduces asynchronous background processing for these operations. This update ensures better resource utilization and aligns the connector with more recent Kafka client capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note that this change may break |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
fd4c04d to
a14a3f3
Compare
|
Took another look at some stashed changes and removed the second client altogether. Kafka 3.0.0 added a method that returns current lag for a partition from a consumer's local state (last received end offset minus last known position). |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @ahmedabu98 @liferoad @fozzie15 |
Continuing from #36075, this PR removes support for old Kafka client libraries, requiring at least Kafka 3.9.1 or newer. Note that every version of Kafka <4.0.0 still supports API protocol versions <0.10.0 and the compatibility matrix indicates that versions of Kafka >=3.0.0 would provide the best compatibility in combination with versions of Kafka >=4.0.0.
This PR leverages
Consumer.position(TopicPartition)andConsumer.currentLag(TopicPartition)to update the end offset estimator (reduced to anAtomicLongper restriction tracker) using local state.I intend to backport this change to
KafkaUnboundedReaderin a separate PR.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.