Skip to content

Commit 3eba587

Browse files
committed
Merge branch 'master' into add_tpch_suite
2 parents 56f52b5 + 1465086 commit 3eba587

File tree

32 files changed

+761
-198
lines changed

32 files changed

+761
-198
lines changed

.asf.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,6 @@ github:
2424
- arrow
2525
enabled_merge_buttons:
2626
squash: true
27+
squash_commit_message: PR_TITLE_AND_DESC
2728
merge: false
2829
rebase: false

.github/pull_request_template.md

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,14 @@
11
<!--
2-
Thanks for sending a pull request! Please keep the following tips in mind:
32
- Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
4-
- Make your PR title clear and descriptive, summarizing what this PR changes.
5-
- Provide a concise example to reproduce the issue, if possible.
6-
- Keep the PR description up to date with all changes.
73
-->
8-
94
# Which issue does this PR close?
105

11-
<!--
12-
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
13-
-->
14-
15-
Closes #.
6+
Closes #<issue_number>
167

17-
# Rationale for this change
18-
<!--
19-
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
20-
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
21-
-->
8+
# Rationale for this change
229

2310
# What changes are included in this PR?
24-
<!--
25-
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
26-
-->
2711

2812
# Are there any user-facing changes?
29-
<!--
30-
If there are user-facing changes then we may require documentation to be updated before approving the PR.
31-
-->
32-
33-
<!--
34-
If there are any breaking changes to public APIs, please add the `api change` label.
35-
-->
3613

3714
# How was this patch tested?
38-
<!--
39-
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
40-
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
41-
If tests were not added, please describe why they were not added and/or why it was difficult to add.
42-
-->

.github/workflows/tpcds-reusable.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,14 @@ jobs:
190190
if: always()
191191
uses: actions/upload-artifact@v4
192192
with:
193-
name: unit-tests-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver }}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || '' }}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
193+
name: unit-tests-reports-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver }}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || '' }}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
194194
path: "**/target/surefire-reports/*.xml"
195-
195+
- name: Upload unit tests log
196+
if: failure()
197+
uses: actions/upload-artifact@v4
198+
with:
199+
name: unit-tests-logs-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver }}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || '' }}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
200+
path: "**/target/unit-tests.log"
196201
- name: Upload auron (Spark ${{ inputs.sparkver }}, Scala ${{ inputs.scalaver }}, JDK ${{ inputs.javaver }})
197202
uses: actions/upload-artifact@v4
198203
with:

.rat-excludes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,4 @@ build/apache-maven-*/**
3737
**/tpch-queries/**
3838
**/tpch-query-results/**
3939

40+
src/main/resources/auron-build-info.properties

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ futures-util = "0.3.31"
9090
hashbrown = "0.14.5"
9191
itertools = "0.14.0"
9292
jni = "0.20.0"
93-
log = "0.4.28"
93+
log = "0.4.29"
9494
lz4_flex = "0.12.0"
9595
num = "0.4.2"
9696
object_store = "0.12.4"
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
rootLogger.level = info
19+
rootLogger.appenderRef.file.ref = File
20+
21+
#File Appender
22+
appender.file.type = File
23+
appender.file.name = File
24+
appender.file.fileName = target/unit-tests.log
25+
appender.file.layout.type = PatternLayout
26+
appender.file.layout.pattern = %d{HH:mm:ss.SSS} %t %p %c{1}: %m%n%ex
27+
28+
#Console Appender
29+
appender.console.type = Console
30+
appender.console.name = STDOUT
31+
appender.console.target = SYSTEM_OUT
32+
appender.console.layout.type = PatternLayout
33+
appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %maxLen{%m}{512}%n%ex{8}%n
34+
appender.console.filter.threshold.type = ThresholdFilter
35+
appender.console.filter.threshold.level = warn
36+
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
rootLogger.level = info
19+
rootLogger.appenderRef.file.ref = File
20+
21+
#File Appender
22+
appender.file.type = File
23+
appender.file.name = File
24+
appender.file.fileName = target/unit-tests.log
25+
appender.file.layout.type = PatternLayout
26+
appender.file.layout.pattern = %d{HH:mm:ss.SSS} %t %p %c{1}: %m%n%ex
27+
28+
#Console Appender
29+
appender.console.type = Console
30+
appender.console.name = STDOUT
31+
appender.console.target = SYSTEM_OUT
32+
appender.console.layout.type = PatternLayout
33+
appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %maxLen{%m}{512}%n%ex{8}%n
34+
appender.console.filter.threshold.type = ThresholdFilter
35+
appender.console.filter.threshold.level = warn
36+

dev/mvn-build-helper/build-native.sh

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
# limitations under the License.
1818
#
1919

20-
set -ex
20+
set -o pipefail
2121

2222
# Preserve the calling directory
2323
_CALLING_DIR="$(pwd)"
@@ -60,16 +60,25 @@ checksum() {
6060
exit 1
6161
fi
6262

63-
echo "$features_arg" | $hash_cmd | awk '{print $1}'
63+
feat_sum="$(echo "$features_arg" | $hash_cmd | awk '{print $1}' )"
6464

65-
find Cargo.toml Cargo.lock native-engine "$cache_libpath" | \
65+
files_sum="$(
66+
find Cargo.toml Cargo.lock native-engine "$cache_libpath" | \
6667
xargs $hash_cmd 2>&1 | \
6768
sort -k1 | \
6869
$hash_cmd | awk '{print $1}'
70+
)"
71+
72+
printf "%s%s" "$feat_sum" "$files_sum" | $hash_cmd | awk '{print $1}'
6973
}
7074

7175
if [ -f "$cache_libpath" ]; then
72-
old_checksum="$(cat "$cache_checksum_file" 2>&1 || true)"
76+
if [ -f "$cache_checksum_file" ]; then
77+
old_checksum="$(cat "$cache_checksum_file")"
78+
else
79+
old_checksum="No checksum file found."
80+
fi
81+
7382
new_checksum="$(checksum)"
7483

7584
echo -e "old build-checksum: \n$old_checksum\n========"

dev/reformat

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,14 @@ function run_maven() {
4040
fi
4141
}
4242

43+
# check or format the rust code
44+
if [[ "$CHECK" == "true" ]]; then
45+
cargo fmt --check
46+
else
47+
cargo fix --all --allow-dirty --allow-staged --allow-no-vcs
48+
cargo fmt --all -q --
49+
fi
50+
4351
# Check or format all code, including third-party code, with spark-3.5
4452
sparkver=spark-3.5
4553
for celebornver in celeborn-0.5 celeborn-0.6
@@ -53,11 +61,3 @@ for sparkver in "${sparkvers[@]}"
5361
do
5462
run_maven -P"${sparkver}"
5563
done
56-
57-
# check or format the rust code
58-
if [[ "$CHECK" == "true" ]]; then
59-
cargo fmt --check
60-
else
61-
cargo fix --all --allow-dirty --allow-staged --allow-no-vcs
62-
cargo fmt --all -q --
63-
fi

0 commit comments

Comments
 (0)