GH-50087: [Docs][C++] Fix sentence structure in memory.rst regarding MemoryManager#50324
Conversation
* Removes a duplicate line * Minor grammer fix Signed-off-by: OmBiradar <ombiradar04@gmail.com>
|
|
There was a problem hiding this comment.
Pull request overview
This PR cleans up the C++ memory documentation by removing a duplicated sentence fragment in the arrow::Device / arrow::MemoryManager explanation, improving readability without changing meaning.
Changes:
- Removed a duplicated/redundant description of
arrow::MemoryManagerallocation behavior. - Left the remaining paragraph with a single, clear example referencing
arrow::MemoryPoolon the CPU.
|
cc: @amoeba |
arrow::MemoryManagerarrow::MemoryManager
|
Hey @OmBiradar, thanks for the PR. The patch looks good. Before we approve and merge, could you make some changes to the issue title and PR title to help maintainers and future contributors out?
|
arrow::MemoryManagermemory.rst regarding MemoryManager
|
Hey @amoeba I have changed the titles of both the PR and the Issue. Let me know if its ok. I will keep in mind the points you mentioned in all my future PR's and issues raised. Thanks for the help! |
memory.rst regarding MemoryManagerMemoryManager
MemoryManagerMemoryManager
|
Thanks @OmBiradar |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 43e2bbe. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
In file
docs/source/cpp/memory.rst:Rationale for this change
I believe the statement
was repeated twice and there was some grammatical mistake in the same paragraph
MemoryManager#50087