GH-45118: [Packaging] Use armored keyring for APT repository #45131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using the keybox format for keyring because we have multiple GPG keys. It seems that we should use the armored format for keyring. libapt-pkg 2.9.16 or later shipped by Debian trixie rejects the keybox format files. So we should use the armored format.
|
@github-actions crossbow submit debian-* ubuntu-* |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit debian-* ubuntu-* |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit debian-* ubuntu-* |
|
Revision: d383f1c Submitted crossbow builds: ursacomputing/crossbow @ actions-c9f841cf10
|
assignUser
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We're using the keybox format for keyring because we have multiple GPG keys. It seems that we should use the armored format for keyring.
libapt-pkg 2.9.16 or later shipped by Debian trixie rejects the keybox format files. So we should use the armored format.
What changes are included in this PR?
Use
.ascnot.gpgfor keyring.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.