Skip to content

Commit 527ddb0

Browse files
authored
GH-47939: [R] Update CRAN packaging checklist to update checksums and have make build call make clean (#47944)
### Rationale for this change - checksum update not part of instructions - non-obvious need to call make clean ### What changes are included in this PR? - update instructions and makefile ### Are these changes tested? I will test locally before marking this as ready for review ### Are there any user-facing changes? No * GitHub Issue: #47939 Authored-by: Nic Crane <[email protected]> Signed-off-by: Nic Crane <[email protected]>
1 parent 2119a27 commit 527ddb0

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

r/Makefile

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ sync-cpp:
4848
cp -p ../LICENSE.txt tools/
4949
sed -i"" -e "s/\.env/dotenv/g" tools/cpp/CMakeLists.txt
5050

51-
build: doc sync-cpp
51+
build:
52+
$(MAKE) clean
53+
$(MAKE) doc
54+
$(MAKE) sync-cpp
5255
R CMD build ${args} .
5356

5457
check: build
@@ -60,12 +63,12 @@ release: build
6063
rm -rf arrow.Rcheck/
6164

6265
clean:
63-
-rm src/*.o
64-
-rm src/*.so
65-
-rm src/*.dll
66-
-rm src/Makevars
67-
-rm src/Makevars.win
66+
-rm -f src/*.o
67+
-rm -f src/*.so
68+
-rm -f src/*.dll
69+
-rm -f src/Makevars
70+
-rm -f src/Makevars.win
6871
-rm -rf arrow.Rcheck/
6972
-rm -rf libarrow/
70-
-rm -rf tools/cpp/ tools/dotenv tools/NOTICE.txt tools/LICENSE.txt tools/checksums
73+
-rm -rf tools/cpp/ tools/dotenv tools/NOTICE.txt tools/LICENSE.txt
7174
-find . -name "*.orig" -delete

r/PACKAGING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ _Wait for the release candidate to be created._
5858
- [ ] Run `urlchecker::url_check()` on the R directory.
5959
- [ ] Create a PR entitled `WIP: [R] Verify CRAN release-X.Y.Z-rcX`. Add a comment `@github-actions crossbow submit --group r` to run all R crossbow jobs against the CRAN-specific release branch.
6060
- [ ] Run `Rscript tools/update-checksums.R <libarrow version>` to download the checksums for the pre-compiled binaries from the ASF artifactory into the tools directory.
61-
- [ ] Regenerate arrow_X.Y.Z.tar.gz (i.e., `make build`).
61+
- [ ] Commit the checksums: `git add -f tools/checksums/ && git commit -m "[CRAN] Add checksums"`
62+
- [ ] Regenerate arrow_X.Y.Z.tar.gz (i.e., `make build`). This will clean old artifacts, regenerate documentation, sync C++ files, and build the package.
6263

6364
## Check Binary Arrow C++ Distributions Specific to the R Package
6465

0 commit comments

Comments
 (0)