Variant to arrow utf8 #8600
Open
Variant to arrow utf8 #8600
+196
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klion26
reviewed
Oct 14, 2025
|
|
||
| perfectly_shredded_to_arrow_primitive_test!( | ||
| get_variant_perfectly_shredded_utf8_as_utf8, | ||
| DataType::Utf8, |
There was a problem hiding this comment.
Do we need to add tests for other types(LargeUtf8/Utf8View) here?
The test here wants to cover the variant_get logic, and the tests added in variant_to_arrow.rs were to cover the logic of the builder?
| TimestampNano(VariantToTimestampArrowRowBuilder<'a, datatypes::TimestampNanosecondType>), | ||
| TimestampNanoNtz(VariantToTimestampNtzArrowRowBuilder<'a, datatypes::TimestampNanosecondType>), | ||
| Date(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Date32Type>), | ||
| StringView(VariantToUtf8ViewArrowBuilder<'a>), |
There was a problem hiding this comment.
We added StringView to the PrimitiveVariantToArrowRowBuilder and the other two to StringVariantToArrowRowBuilder, is there a particular reason for this?
|
|
||
| define_variant_to_primitive_builder!( | ||
| struct VariantToUtf8ArrowRowBuilder<'a> | ||
| |item_capacity, data_capacity: usize| -> StringBuilder {StringBuilder::with_capacity(item_capacity, data_capacity)}, |
There was a problem hiding this comment.
Suggested change
| |item_capacity, data_capacity: usize| -> StringBuilder {StringBuilder::with_capacity(item_capacity, data_capacity)}, | |
| |item_capacity, data_capacity: usize| -> StringBuilder { StringBuilder::with_capacity(item_capacity, data_capacity) }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add support for Variant::Utf-8, LargeUtf8, Utf8View. This needs to add a new builder VariantToStringArrowRowBuilder, because LargeUtf8, Utf8View are not ArrowPritimitiveType's
What changes are included in this PR?
data_capacitytomake_string_variant_to_arrow_row_builderto support string types.make_string_variant_to_arrow_row_builderinvariant_getto include the variable.Are these changes tested?
Added a variant_get test for utf8 type and created two separate tests for largeUtf8 and Utf8view because these types can't be shredded.
Are there any user-facing changes?
No