Skip to content

Commit eecd8c1

Browse files
committed
remove rom_iter_primitive
1 parent a2ba44d commit eecd8c1

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

arrow-array/src/array/list_view_array.rs

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -297,16 +297,6 @@ impl<OffsetSize: OffsetSizeTrait> GenericListViewArray<OffsetSize> {
297297
}
298298
}
299299

300-
/// Creates a [`GenericListViewArray`] from an iterator of primitive values
301-
///
302-
pub fn from_iter_primitive<T, P, I>(_iter: I) -> Self
303-
where
304-
T: ArrowPrimitiveType,
305-
P: IntoIterator<Item = Option<<T as ArrowPrimitiveType>::Native>>,
306-
I: IntoIterator<Item = Option<P>>,
307-
{
308-
panic!("Not yet implemented, wait list view array builder to be implemented")
309-
}
310300
}
311301

312302
impl<'a, OffsetSize: OffsetSizeTrait> ArrayAccessor for &'a GenericListViewArray<OffsetSize> {
@@ -968,23 +958,4 @@ mod tests {
968958
assert_eq!(values, vec![Some(vec![1, 2, 3]), None, Some(vec![4, 5, 6])])
969959
}
970960

971-
#[test]
972-
#[should_panic(
973-
expected = "Not yet implemented, wait list view array builder to be implemented"
974-
)]
975-
fn test_from_iter_primitive() {
976-
let data = vec![
977-
Some(vec![Some(0), Some(1), Some(2)]),
978-
Some(vec![Some(3), Some(4), Some(5)]),
979-
Some(vec![Some(6), Some(7)]),
980-
];
981-
let list_array = ListViewArray::from_iter_primitive::<Int32Type, _, _>(data);
982-
983-
let field = Arc::new(Field::new("item", DataType::Int32, true));
984-
let sizes = ScalarBuffer::from(vec![3, 3, 2]);
985-
let offsets = ScalarBuffer::from(vec![0, 3, 6]);
986-
let values = Int32Array::from(vec![0, 1, 2, 3, 4, 5, 6, 7]);
987-
let another = ListViewArray::new(field, offsets, sizes, Arc::new(values), None);
988-
assert_eq!(list_array, another)
989-
}
990961
}

0 commit comments

Comments
 (0)