Skip to content

Commit 3317989

Browse files
alambetseidl
andauthored
Minor: make it easier to find fix instructions when cargo fmt on parquet fails (#6886)
* Minor: make it easier to find instructions when fmt fails * purposely introduce a fmt issue * Revert "purposely introduce a fmt issue" This reverts commit 440e520. * Update .github/workflows/rust.yml Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com> --------- Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com>
1 parent 1079360 commit 3317989

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/rust.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,13 @@ jobs:
101101
- name: Format arrow
102102
run: cargo fmt --all -- --check
103103
- name: Format parquet
104-
# Many modules in parquet are skipped, so check parquet separately. If this check fails, run:
105-
# cargo fmt -p parquet -- --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs`
106-
# from the top level arrow-rs directory and check in the result.
104+
# Many modules in parquet are skipped, so check parquet separately
107105
# https://github.com/apache/arrow-rs/issues/6179
108106
working-directory: parquet
109-
run: cargo fmt -p parquet -- --check --config skip_children=true `find . -name "*.rs" \! -name format.rs`
107+
run: |
108+
# if this fails, run this from the parquet directory:
109+
# cargo fmt -p parquet -- --config skip_children=true `find . -name "*.rs" \! -name format.rs`
110+
cargo fmt -p parquet -- --check --config skip_children=true `find . -name "*.rs" \! -name format.rs`
110111
- name: Format object_store
111112
working-directory: object_store
112113
run: cargo fmt --all -- --check

0 commit comments

Comments
 (0)