From 46be8604b89805dfda711240678a75e6421e4432 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 20 Mar 2025 15:18:19 -0400 Subject: [PATCH 1/5] Fix lint job --- .github/workflows/rust.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 0972e46..9867be7 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -39,8 +39,6 @@ jobs: image: amd64/rust steps: - uses: actions/checkout@v4 - - name: Setup Rust toolchain - uses: ./.github/actions/setup-builder - name: Setup rustfmt run: rustup component add rustfmt - name: Format object_store From eeabdaa37bba949308a800e2a482d57cb49178d8 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 20 Mar 2025 15:22:21 -0400 Subject: [PATCH 2/5] Fix CI jobs --- .github/workflows/object_store.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/object_store.yml b/.github/workflows/object_store.yml index 1728b3a..44b30a6 100644 --- a/.github/workflows/object_store.yml +++ b/.github/workflows/object_store.yml @@ -41,8 +41,6 @@ jobs: image: amd64/rust steps: - uses: actions/checkout@v4 - - name: Setup Rust toolchain - uses: ./.github/actions/setup-builder - name: Setup Clippy run: rustup component add clippy # Run different tests for the library on its own as well as @@ -189,12 +187,10 @@ jobs: - uses: actions/checkout@v4 with: submodules: true - - name: Setup Rust toolchain - uses: ./.github/actions/setup-builder - with: - target: wasm32-unknown-unknown,wasm32-wasip1 - name: Install clang (needed for ring) run: apt-get update && apt-get install -y clang + - name: Install wasm32-unknown-unknown + run: rustup toolchain install stable --target wasm32-unknown-unknown,wasm32-wasip1 - name: Build wasm32-unknown-unknown run: cargo build --target wasm32-unknown-unknown - name: Build wasm32-wasip1 From fde36a6fea50e5fc2361d55206400f83433095ae Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 20 Mar 2025 15:27:31 -0400 Subject: [PATCH 3/5] install targets --- .github/workflows/object_store.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/object_store.yml b/.github/workflows/object_store.yml index 44b30a6..93d289f 100644 --- a/.github/workflows/object_store.yml +++ b/.github/workflows/object_store.yml @@ -190,9 +190,11 @@ jobs: - name: Install clang (needed for ring) run: apt-get update && apt-get install -y clang - name: Install wasm32-unknown-unknown - run: rustup toolchain install stable --target wasm32-unknown-unknown,wasm32-wasip1 + run: rustup target add wasm32-unknown-unknown - name: Build wasm32-unknown-unknown run: cargo build --target wasm32-unknown-unknown + - name: Install wasm32-wasip1 + run: rustup target add wasm32-wasip1 - name: Build wasm32-wasip1 run: cargo build --all-features --target wasm32-wasip1 From 5448ff5a7ed70c9c22a95c5c3a4e6f8a3e12c8ae Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 20 Mar 2025 15:29:30 -0400 Subject: [PATCH 4/5] Add labeler --- .github/workflows/dev_pr/labeler.yml | 55 ++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 .github/workflows/dev_pr/labeler.yml diff --git a/.github/workflows/dev_pr/labeler.yml b/.github/workflows/dev_pr/labeler.yml new file mode 100644 index 0000000..cae0150 --- /dev/null +++ b/.github/workflows/dev_pr/labeler.yml @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +arrow: + - changed-files: + - any-glob-to-any-file: + - 'arrow-arith/**/*' + - 'arrow-array/**/*' + - 'arrow-buffer/**/*' + - 'arrow-cast/**/*' + - 'arrow-csv/**/*' + - 'arrow-data/**/*' + - 'arrow-flight/**/*' + - 'arrow-integration-test/**/*' + - 'arrow-integration-testing/**/*' + - 'arrow-ipc/**/*' + - 'arrow-json/**/*' + - 'arrow-avro/**/*' + - 'arrow-ord/**/*' + - 'arrow-row/**/*' + - 'arrow-schema/**/*' + - 'arrow-select/**/*' + - 'arrow-string/**/*' + - 'arrow/**/*' + +arrow-flight: + - changed-files: + - any-glob-to-any-file: + - 'arrow-flight/**/*' + +parquet: + - changed-files: + - any-glob-to-any-file: [ 'parquet/**/*' ] + +parquet-derive: + - changed-files: + - any-glob-to-any-file: [ 'parquet_derive/**/*' ] + +object-store: + - changed-files: + - any-glob-to-any-file: [ 'object_store/**/*' ] From aebbc6e1e49cb851ecd598e1ac4be2d5d44a28e4 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 20 Mar 2025 15:32:18 -0400 Subject: [PATCH 5/5] Remove labeler --- .github/workflows/dev_pr.yml | 51 -------------------------- .github/workflows/dev_pr/labeler.yml | 55 ---------------------------- 2 files changed, 106 deletions(-) delete mode 100644 .github/workflows/dev_pr.yml delete mode 100644 .github/workflows/dev_pr/labeler.yml diff --git a/.github/workflows/dev_pr.yml b/.github/workflows/dev_pr.yml deleted file mode 100644 index 0d60ae0..0000000 --- a/.github/workflows/dev_pr.yml +++ /dev/null @@ -1,51 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -name: dev_pr - -concurrency: - group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} - cancel-in-progress: true - -# Trigger whenever a PR is changed (title as well as new / changed commits) -on: - pull_request_target: - types: - - opened - - edited - - synchronize - -jobs: - process: - name: Process - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - steps: - - uses: actions/checkout@v4 - - - name: Assign GitHub labels - if: | - github.event_name == 'pull_request_target' && - (github.event.action == 'opened' || - github.event.action == 'synchronize') - uses: actions/labeler@v5.0.0 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - configuration-path: .github/workflows/dev_pr/labeler.yml - sync-labels: true diff --git a/.github/workflows/dev_pr/labeler.yml b/.github/workflows/dev_pr/labeler.yml deleted file mode 100644 index cae0150..0000000 --- a/.github/workflows/dev_pr/labeler.yml +++ /dev/null @@ -1,55 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -arrow: - - changed-files: - - any-glob-to-any-file: - - 'arrow-arith/**/*' - - 'arrow-array/**/*' - - 'arrow-buffer/**/*' - - 'arrow-cast/**/*' - - 'arrow-csv/**/*' - - 'arrow-data/**/*' - - 'arrow-flight/**/*' - - 'arrow-integration-test/**/*' - - 'arrow-integration-testing/**/*' - - 'arrow-ipc/**/*' - - 'arrow-json/**/*' - - 'arrow-avro/**/*' - - 'arrow-ord/**/*' - - 'arrow-row/**/*' - - 'arrow-schema/**/*' - - 'arrow-select/**/*' - - 'arrow-string/**/*' - - 'arrow/**/*' - -arrow-flight: - - changed-files: - - any-glob-to-any-file: - - 'arrow-flight/**/*' - -parquet: - - changed-files: - - any-glob-to-any-file: [ 'parquet/**/*' ] - -parquet-derive: - - changed-files: - - any-glob-to-any-file: [ 'parquet_derive/**/*' ] - -object-store: - - changed-files: - - any-glob-to-any-file: [ 'object_store/**/*' ]