Skip to content

Should ObjectStore sizes be u64 instead of usize? #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ttencate opened this issue Jul 25, 2024 · 5 comments
Closed

Should ObjectStore sizes be u64 instead of usize? #61

ttencate opened this issue Jul 25, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@ttencate
Copy link

I noticed that object_store::ObjectMeta::size is of type usize. On 32-bit platforms, this would limit the value to 4 GiB.

There are object stores out there that accept files larger than 4 GiB. For instance, Google Cloud Storage supports objects up to 5 TiB. Common local filesystems (with the exception of FAT32) also support larger files.

There might be more APIs where usize is used to represent file size, but I didn't check.

@ttencate ttencate added the enhancement New feature or request label Jul 25, 2024
@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

I don't think it was intentional to limit the size of objects to 4GB on 32-bit platforms (though maybe @tustvold or @carols10cents have some different memory)

@tustvold
Copy link
Contributor

It wasn't intentional, however, it has lacked for a compelling use-case to justify making what would be a very disruptive change.

One suggestion in the past has been wasm32, but the support for this is currently fairly limited.

TLDR yes it should be u64, but there hasn't really been a good use-case nor someone willing to drive support for 32-bit platforms forward

@tustvold
Copy link
Contributor

Closing this as duplicate of apache/arrow-rs#5351

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2024
@ttencate
Copy link
Author

I understand, just thought I'd mention it (and I failed to find the duplicate). Thank you the impressively quick response!

@alamb
Copy link
Contributor

alamb commented Mar 20, 2025

Migrating from arrow-rs issue #6111

@alamb alamb transferred this issue from apache/arrow-rs Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants