Skip to content

Commit 3e12e1a

Browse files
authored
Run CI on PRs (#336)
* . * clippy fixes * no need for a path filter
1 parent cdf3ed1 commit 3e12e1a

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

.github/workflows/object_store.yml renamed to .github/workflows/ci.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
# under the License.
1717

1818
---
19-
# tests for `object_store` crate
20-
name: object_store
19+
20+
name: CI
2121

2222
concurrency:
2323
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
@@ -29,9 +29,6 @@ on:
2929
branches:
3030
- main
3131
pull_request:
32-
paths:
33-
- object_store/**
34-
- .github/**
3532

3633
jobs:
3734
clippy:
@@ -77,7 +74,7 @@ jobs:
7774
steps:
7875
- uses: actions/checkout@v4
7976
- name: Run cargo doc
80-
run: cargo doc --document-private-items --no-deps --workspace --all-features
77+
run: cargo doc --document-private-items --no-deps --all-features
8178

8279
# test the crate
8380
# This runs outside a container to workaround lack of support for passing arguments

src/delimited.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ impl LineDelimiter {
109109
}
110110
},
111111
};
112-
let end_offset = record_ends.last().unwrap_or(start_offset);
112+
let end_offset = record_ends.next_back().unwrap_or(start_offset);
113113
if start_offset != end_offset {
114114
self.complete.push_back(val.slice(start_offset..end_offset));
115115
}

src/integration.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ pub async fn put_opts(storage: &dyn ObjectStore, supports_update: bool) {
657657
.put_opts(&path, "c".into(), PutMode::Update(v1.clone().into()).into())
658658
.await
659659
.unwrap_err();
660-
assert!(matches!(err, Error::NotImplemented { .. }), "{err}");
660+
assert!(matches!(err, Error::NotImplemented), "{err}");
661661

662662
return;
663663
}

0 commit comments

Comments
 (0)