Skip to content

feat: add Iceberg table tag management UI and API#4164

Open
fightBoxing wants to merge 51 commits intoapache:masterfrom
fightBoxing:feature/iceberg-tag-management
Open

feat: add Iceberg table tag management UI and API#4164
fightBoxing wants to merge 51 commits intoapache:masterfrom
fightBoxing:feature/iceberg-tag-management

Conversation

@fightBoxing
Copy link
Copy Markdown

@fightBoxing fightBoxing commented Apr 2, 2026

Summary

  • Add createTag and deleteTag API endpoints for Iceberg tables (POST/DELETE /ams/v1/tables/catalogs/{catalog}/dbs/{db}/tables/{table}/tags)
  • Implement tag creation and deletion logic in MixedAndIcebergTableDescriptor using Iceberg TableMetadata API
  • Add CreateTagRequest DTO in TableController to replace unsafe Map<String, Object> deserialization
  • Add createTag / deleteTag service functions in frontend table.service.ts
  • Add Create Tag modal and Delete Tag confirmation in Selector.vue with snapshot ID and optional max-ref-age inputs
  • Extend FormatTableDescriptor interface and ServerTableDescriptor with tag management methods

Test Plan

  • Start Amoro server and open Web UI
  • Navigate to an Iceberg table → Tags tab
  • Click "Create Tag", fill in tag name and snapshot ID, confirm creation succeeds
  • Verify new tag appears in the tag list
  • Click delete icon on a tag, confirm deletion succeeds
  • Verify deleted tag is removed from the list
  • Verify Checkstyle: 0 violations
  • Verify Spotless: BUILD SUCCESS

zhoujinsong and others added 30 commits June 25, 2024 14:19
@zhoujinsong
Update version to 0.7.0-incubating
66a0d8e
@xleoken @zhoujinsong
[AMORO-2960] Support paimon s3 based catalog (apache#2972)
1e7c10b 
* [AMORO-2960] Support paimon s3 based catalog

* trigger ci
@chouchouji @zhoujinsong
[AMORO-2941] Complete translations for amoro dashboard (apache#2958)
dcc78c1 
* [AMORO-2941] Complete translations for amoro dashboard

* [AMORO-2941] Format code

* [AMORO-2941] Optimize translations
@xleoken @zhoujinsong
[Improvement] Add maven-mirror to speed up building image doc (apache…
52ddb36 
…#2984)
@zhoujinsong
[Improvement] Fix maven jar plugin configuration for apache release (a…
455f283 
…pache#2975)

Fix jar plugin configuration for apache release
@zhoujinsong
[Improvement] Add NOTICE-binary & LICENSE-binary for binary release (a…
2ed6316 
…pache#2985)

* Add NOTICE-binary & LICENSE-binary files

* Remove useless plugin

* Rollback dependency change

* Fix rat plugin check rules
@zhoujinsong
[Improvement] Add more checking rules for importing guava clesses (ap…
6bfbcff 
…ache#2976)

* Add check rules for iceberg and paimon shade guava clesses

* Remove duplicate checking rule
@zhoujinsong
[Hotfix] Fix amoro docker image build ci (apache#2987)
deb6ddc 
Fix amoro docker image build ci
@zhoujinsong
Improve hadoop profile
4d4611c
@zhoujinsong
Merge master & Fix conflicts
cdc2602
@zhoujinsong
Merge branch 'master' into 0.7.x
729cfd1
@zhoujinsong
Add test-jar goal
5d28fef
@zhoujinsong
Support to skip java doc plugin for trino module
75fdff9
@zhoujinsong
Merge branch 'master' into 0.7.x
3a89437
@zhoujinsong
Merge branch 'master' into 0.7.x
d8e2784
@link3280 @zhoujinsong
[AMORO-3050] Fix AMS crashes if javalin stop timeouts (apache#3052)
a6b7786 
(cherry picked from commit 94b2298)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@link3280 @zhoujinsong
[AMORO-3056] Support graceful shutdown for AMS (apache#3057)
b0a1488 
(cherry picked from commit f5d2e85)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@chouchouji @zhoujinsong
[Hotfix] Fix the function that convert ms (apache#3069)
f3868db 
(cherry picked from commit a550103)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@xxubai @zhoujinsong
[AMORO-2555] Tag dangling delete snapshot commits (apache#3058)
9d4ea99 
* Tag dangling delete snapshot commits

* make maintain commits public

* Re-gen table metastore java code via thrift

(cherry picked from commit 7066300)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@tcodehuber @zhoujinsong
[AMORO-3076] Prevent the table name from being truncated prematurely (a…
c8ad837 
…pache#3077)

(cherry picked from commit 3659610)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@zhoujinsong
[AMORO-3098] Load log4j2.xml under AMORO_CONF_DIR first (apache#3099)
c69faef 
Load log4j2.xml under AMORO_CONF_DIR first

(cherry picked from commit bc0034a)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@nicochen @zhoujinsong
[AMORO-3132]High available service should not close curator client be…
f0400a4 
…fore LeaderLatch closing (apache#3133)

[AMORO-3132][Bug]:High available service should not curator client before LeaderLatch closing apache#3132

(cherry picked from commit 79f1bea)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@klion26 @zhoujinsong
[AMORO-3128] Make yarn application name for flink optimizer more mean…
a26da28 
…ingful (apache#3129)

(cherry picked from commit 2bf68a1)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@rfyu @zhoujinsong
[AMORO-3141] When a master/backup switch occurs, close the `planExecu…
5200a86 
…tor` thread pool (apache#3142)

(cherry picked from commit a8b2ff5)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@klion26 @zhoujinsong
[AMORO-3145] Filter out info log for CodecPool in optimizer (apache#3185
dd47342 
)

[AMORO-3145] Filter out info log for CodecPool

Currently there will be many logs for (de)compressor from CodecPool, and
seems there is no other meaningful info log from this class, so we change
 the log level from CodecPool from info to warn to filter out these logs

This only affect the local optimizer, and user need to change the configuration
if they use flink/spark optimzier.

(cherry picked from commit b52f64d)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@engraving-knife @xxubai @zhoujinsong
[AMORO-3153]Modify the implementation class of the thrift server (apa…
b233c4c 
…che#3154)

Modify the implementation class of the thrift server

Co-authored-by: xiaosefeng <xiaosefeng@tencent.com>
Co-authored-by: Xavier Bai <xuba@apache.org>
(cherry picked from commit 8207efc)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@Aireed @zhoujinsong
[AMORO-3194]improvement: optimize plan log print (apache#3212)
a13a95e 
improvement: optimize log print

Co-authored-by: 王涛 <wangtao@HIH-L-10114.local>
(cherry picked from commit 7081bbc)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@rfyu @zhoujinsong
[AMORO-3111]Avoid optimization state blocking in planning (apache#3115)
64ac2a7 
* Avoid optimization state blocking in planning

* modify the optimizing status in memory

* fix conflict and rollback configuration

(cherry picked from commit 292111f)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@rfyu @zhoujinsong
[AMORO-3110] Avoid optimization status blocking in running (apache#3113)
f1667cb 
* [AMORO-3110] Avoid optimization status blocking in running

* format

* Ignore the exception when it occurs and do not perform a rollback

(cherry picked from commit 9877c20)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@xxubai @zhoujinsong
[AMORO-3110] Extract error message in optimizers (apache#3130)
3974b1e 
extract error message in optimizers

(cherry picked from commit 5adbfbf)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
xxubai and others added 21 commits October 11, 2024 15:56
@xxubai @zhoujinsong
[AMORO-3110] Do not throw exception when retry task in optimizer keep…
50d8a80 
…er (apache#3223)

Do not throw exception when retry task in optimizer keeper

(cherry picked from commit a2bc71a)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@majin1102 @zhoujinsong
[Amoro-3196]: Fix scheduling hungry issue (apache#3203)
aebd12c 
* Amoro-3196: Fix scheduling hungry issue

* Apply spotless

---------

Co-authored-by: majin.nathan <majin.nathan@bytedance.com>
(cherry picked from commit 5027abe)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@chouchouji @zhoujinsong
Merge apache#3152 and fix conflicts
05883ca
@link3280 @zhoujinsong
[Hotfix] Fix wrong javadoc for TableRuntimeRefreshExecutor (apache#3051)
f845e75 
Fix wrong javadoc for TableRuntimeRefreshExecutor

(cherry picked from commit 1db63a6)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@xieyi888 @zhoujinsong
[Doc]Fix typo in managing-optimizers.md (apache#3059)
545fc02 
fix typo in managing-optimizers.md

(cherry picked from commit fafb3f4)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@majin1102 @zhoujinsong
[AMORO-3242] Fix optimizer keeper unregister npe (apache#3243)
7b2f6be 
Fix optimizer keeper unregister npe

Co-authored-by: majin.nathan <majin.nathan@bytedance.com>
(cherry picked from commit 3e17628)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@xxubai @zhoujinsong
[AMORO-2870] Rewrite the task which contain different eq-delete fields (
c4a3932 
apache#3175)

* rewrite multiple delete ids

* update comments

* replace shade guava with google

* replace `computeIfAbsent` with `putIfAbsent` to void projecting schema every time

(cherry picked from commit 6982a32)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@zhoujinsong
Merge apache#3225 & fix conflicts
a05f56c
@zhoujinsong
[AMORO-3228] Rewrite pos delete files not written by optimizing proce…
a2ec9a4 
…ss (apache#3229)

Rewrite pos delete files not written by optimizing

(cherry picked from commit a181281)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@klion26 @zhoujinsong
[AMORO-3302] Make plugin jar optional for packing (apache#3305)
d02f112 
(cherry picked from commit 1d9de04)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@klion26
[AMORO-3303] Optimize the final tarball to keep it within the specifi…
65127ea 
…ed size for 0.7 (apache#3304)

* [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7

* fixup! [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7

* fixup! [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7
@zhoujinsong
Change project version to 0.7.1-incubating
ede4046
@zhoujinsong
[AMORO-3086] Add more tags for amoro docker images built by ci (apach…
27a2c20 
…e#3088)

* Fix amoro image tag error

* Add latest tag configuration for docker image ci

* Fix latest tag configuration for dcoker image

* Fix latest tag configuration for dcoker image

* Fix latest tag configuration for dcoker image

* Fix latest tag configuration for dcoker image

* Fix latest tag configuration for dcoker image

* Fix latest tag configuration for dcoker image

* Rollback changes for test

(cherry picked from commit 0e8fa55)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@zhoujinsong
Change amoro shade version to 0.7.0-incubating (apache#3083)
73c0856 
(cherry picked from commit 587270e)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@7hong @zhoujinsong
[AMORO-3239] Fix stack overflow caused by reading too many partitions…
e73ca0a 
… in the filter (apache#3240)

* [AMORO-3239] Fix stack overflow caused by reading too many partitions in the filter

* [AMORO-3239] Add the "ignore-filter-partition-count" parameter

* move parameter "optimizer.ignore-filter-partition-count" to "self-optimizing.skip-filter-partition-count"

* move parameter "self-optimizing.skip-filter-partition-count" to "refresh-tables.max-pending-partition-count"
@zhoujinsong
Fix some checkstyle errors
b9d6da9
@zhoujinsong
Remove optional dependency and pluin jars for apache release
e9434bd
@zhoujinsong
[AMORO-3323]Exclude hadoop-client-api dependency (apache#3324)
774aa9d 
Exclude hadoop-client-api dependency

(cherry picked from commit b6a3549)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@zhangwl9
[hotfix] fixup column name in TableMetaMapper#selectTableRuntimeMetas (…
a8dd445 
…apache#3331)

Co-authored-by: 张文领 <zhangwl9@chinatelecom.cn>
feat: add Iceberg table tag management UI and API
d5cd173 
- Backend: Add createTag/deleteTag API endpoints in TableController
- Backend: Add createTag/deleteTag interface in FormatTableDescriptor
- Backend: Implement tag operations in MixedAndIcebergTableDescriptor using Iceberg TableOperations
- Backend: Add unsupported exception for Paimon in PaimonTableDescriptor
- Backend: Register /tags routes in DashboardServer and ServerTableDescriptor
- Frontend: Add Create Tag dialog with tag name and snapshot ID inputs in Selector.vue
- Frontend: Add Delete Tag confirmation dialog in Selector.vue
- Frontend: Add createTag/deleteTag API calls in table.service.ts
- Frontend: Add i18n translations for tag operations in en.ts and zh.ts
- Fix: Use plain text input for snapshotId to avoid JS number precision loss for large IDs
refactor: address code review issues for tag management feature
3b680f9 
- Replace Chinese Javadoc with English in FormatTableDescriptor and TableController
- Replace Chinese comments with English in table.service.ts and Selector.vue
- Replace Map<String, Object> unchecked cast with CreateTagRequest DTO in TableController
- Simplify createTag builder logic to avoid duplicate SnapshotRef construction
- Eliminate duplicate base.ref(tagName) call in deleteTag using local variable
@github-actions github-actions bot added type:docs Improvements or additions to documentation module:ams-server Ams server module type:infra type:build labels Apr 2, 2026
@czy006
Copy link
Copy Markdown
Contributor

czy006 commented Apr 3, 2026

@fightBoxing Thank you for your contribution. You need to trigger CI after rebasing the branch to proceed to the review stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module:ams-server Ams server module type:build type:docs Improvements or additions to documentation type:infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.