[AMORO-4147] [Improvement]: Resource leak in CombinedDeleteFilter and MixedDeleteFilter position delete iterators.#4148
Merged
xxubai merged 2 commits intoapache:masterfrom Mar 30, 2026
Conversation
… MixedDeleteFilter position delete iterators.
xxubai
approved these changes
Mar 29, 2026
Contributor
xxubai
left a comment
There was a problem hiding this comment.
Thanks for the contribution ! @slfan1989 . LGTM
Contributor
Author
|
@xxubai Thank you so much for reviewing the code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix resource leak issues in position delete processing.
CloseableIterator<Record>instances are not properly closed inCombinedDeleteFilterandMixedDeleteFilter, which can lead to:Close #4147.
Brief change log
CloseableIterator<Record>in try-with-resources block inpositionMapinitialization (line 397-410)CloseableIterator<Record>in try-with-resources block inpositionMapinitialization (line 369-386)How was this patch tested?
Documentation