From d42d2685e9345ca1862e4e63783073f7cb5be0da Mon Sep 17 00:00:00 2001 From: James Farrell Date: Wed, 22 Jan 2025 19:51:04 +0000 Subject: [PATCH] Bail with an error if no crates specified. Bug: 391657710 Test: manual Change-Id: Idf58eff4f78c72e4641a91b47ad1fbfe84df6917 --- tools/external_crates/crate_tool/src/main.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/external_crates/crate_tool/src/main.rs b/tools/external_crates/crate_tool/src/main.rs index 9a2e9eaaa0..068004ed4a 100644 --- a/tools/external_crates/crate_tool/src/main.rs +++ b/tools/external_crates/crate_tool/src/main.rs @@ -17,7 +17,7 @@ use std::{ path::PathBuf, }; -use anyhow::Result; +use anyhow::{bail, Result}; use clap::{Args, Parser, Subcommand}; use crate_tool::{ default_repo_root, maybe_build_cargo_embargo, ManagedRepo, SemverCompatibilityRule, @@ -166,6 +166,9 @@ impl CrateList { Ok(if self.all { managed_repo.all_crate_names()?.difference(&self.exclude).cloned().collect::>() } else { + if self.crates.is_empty() { + bail!("No crates specified"); + } self.crates.clone() }) }