Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(view): Support to remove transform #59

Closed
wants to merge 1 commit into from
Closed

feat(view): Support to remove transform #59

wants to merge 1 commit into from

Conversation

dengfuping
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@dengfuping dengfuping requested a review from dxq613 July 1, 2019 10:09
@dengfuping dengfuping force-pushed the feature/removeTransform branch from 2f764dc to 6d316f4 Compare July 1, 2019 10:25
hustcc
hustcc reviewed Jul 30, 2020
View reviewed changes
src/view.js
const me = this;
me.transforms = me.transforms.filter(item => item.type !== type);
me._reExecute();
return me;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeTransform 和 executeTransform 的职能区分开？

@hustcc
Copy link
Member

hustcc commented Jul 30, 2020

这个 pr 是否还需要保留，不需要我就关闭了。毕竟太久远了。

@dengfuping
Copy link
Member Author

  • 关掉吧，我自己都忘了还有这个 PR 😂

@dengfuping dengfuping closed this Jul 30, 2020
@hustcc hustcc deleted the feature/removeTransform branch September 28, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

@dxq613 dxq613 Awaiting requested review from dxq613

Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

如何正确的移除 transform ?
2 participants
@dengfuping @hustcc