Skip to content

Commit 561106e

Browse files
refactor: Code formatting
1 parent 2427aab commit 561106e

File tree

4 files changed

+32
-17
lines changed

4 files changed

+32
-17
lines changed

sbomdiff/cli.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
# CLI processing
1616

17+
1718
def main(argv=None):
1819

1920
argv = argv or sys.argv
@@ -74,10 +75,10 @@ def main(argv=None):
7475
# Check both files exist
7576
file_found = True
7677
if not pathlib.Path(args["FILE1"]).exists():
77-
print (f"{args['FILE1']} does not exist")
78+
print(f"{args['FILE1']} does not exist")
7879
file_found = False
7980
if not pathlib.Path(args["FILE2"]).exists():
80-
print (f"{args['FILE2']} does not exist")
81+
print(f"{args['FILE2']} does not exist")
8182
file_found = False
8283
if not file_found:
8384
return -1
@@ -131,10 +132,16 @@ def main(argv=None):
131132
version1, license1 = packages1[package]
132133
version2, license2 = packages2[package]
133134
if version1 != version2:
134-
sbom_out.send_output(f"[VERSION] {package}: Version changed from {version1} to {version2}")
135+
sbom_out.send_output(
136+
f"[VERSION] {package}: "
137+
f"Version changed from {version1} to {version2}"
138+
)
135139
version_changes += 1
136140
if not args["exclude_license"] and license1 != license2:
137-
sbom_out.send_output(f"[LICENSE] {package}: License changed from {license1} to {license2}")
141+
sbom_out.send_output(
142+
f"[LICENSE] {package}: "
143+
f"License changed from {license1} to {license2}"
144+
)
138145
license_changes += 1
139146
else:
140147
# Package must have been removed
@@ -162,5 +169,6 @@ def main(argv=None):
162169

163170
return 0
164171

172+
165173
if __name__ == "__main__":
166174
sys.exit(main())

sbomdiff/cyclonedx_parser.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def parse(self, sbom_file):
2020
return {}
2121

2222
def parse_cyclonedx_json(self, sbom_file):
23-
"""parses CycloneDX JSON BOM file extracting package name, version and license"""
23+
"""parses CycloneDX JSON SBOM extracting package name, version and license"""
2424
data = json.load(open(sbom_file))
2525
packages = {}
2626
# Check that valid CycloneDX JSON file is being processed
@@ -57,7 +57,11 @@ def parse_cyclonedx_xml(self, sbom_file):
5757
try:
5858
for component in components.findall(schema + "component"):
5959
# Only for application and library components
60-
if component.attrib["type"] in ["library", "application", "operating-system"]:
60+
if component.attrib["type"] in [
61+
"library",
62+
"application",
63+
"operating-system",
64+
]:
6165
component_name = component.find(schema + "name")
6266
if component_name is None:
6367
raise KeyError(f"Could not find package in {component}")
@@ -77,7 +81,7 @@ def parse_cyclonedx_xml(self, sbom_file):
7781
if version is not None:
7882
if package not in packages:
7983
packages[package] = [version, license]
80-
except KeyError as e:
84+
except KeyError:
8185
pass
8286

8387
return packages

sbomdiff/output.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def show(self, message):
3434

3535

3636
class SBOMOutput:
37-
"""Output manager """
37+
"""Output manager"""
3838

3939
def __init__(self, filename="console"):
4040
self.filename = filename

sbomdiff/spdx_parser.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def parse(self, sbom_file):
2828
return {}
2929

3030
def parse_spdx_tag(self, sbom_file):
31-
"""parses SPDX tag value BOM file extracting package name, version and license"""
31+
"""parses SPDX tag value file extracting package name, version and license"""
3232
with open(sbom_file) as f:
3333
lines = f.readlines()
3434
packages = {}
@@ -64,7 +64,7 @@ def parse_spdx_json(self, sbom_file):
6464
license = d["licenseConcluded"]
6565
if package not in packages:
6666
packages[package] = [version, license]
67-
except KeyError as e:
67+
except KeyError:
6868
pass
6969

7070
return packages
@@ -75,6 +75,7 @@ def parse_spdx_rdf(self, sbom_file):
7575
lines = f.readlines()
7676
packages = {}
7777
package = ""
78+
license = None
7879
for line in lines:
7980
try:
8081
if line.strip().startswith("<spdx:name>"):
@@ -108,19 +109,21 @@ def parse_spdx_rdf(self, sbom_file):
108109
license = "NOT FOUND"
109110
else:
110111
license = license_match.group(1)
111-
if license.startswith("\"http://spdx.org/licenses/"):
112+
if license.startswith('"http://spdx.org/licenses/'):
112113
# SPDX license identifier. Extract last part of url
113114
license = license.split("/")[-1]
114-
license=license[:-1] # Remove trialing "
115+
license = license[:-1] # Remove trialing "
115116
if "#" in license:
116-
# Extract last part of url after # e.g. http://spdx.org/rdf/terms#noassertion
117+
# Extract last part of url after #
118+
# e.g. http://spdx.org/rdf/terms#noassertion
117119
license = license.split("#")[-1]
118-
license=license[:-1].upper() # Remove trialing " and capitalise
120+
# Remove trialing " and capitalise
121+
license = license[:-1].upper()
119122
# To handle case where license appears before version
120123
if package not in packages and version is not None:
121124
packages[package] = [version, license]
122125
license = None
123-
except KeyError as e:
126+
except KeyError:
124127
pass
125128

126129
return packages
@@ -139,7 +142,7 @@ def parse_spdx_yaml(self, sbom_file):
139142
license = d["licenseConcluded"]
140143
if package not in packages:
141144
packages[package] = [version, license]
142-
except KeyError as e:
145+
except KeyError:
143146
pass
144147

145148
return packages
@@ -178,7 +181,7 @@ def parse_spdx_xml(self, sbom_file):
178181
if package not in packages:
179182
packages[package] = [version, license]
180183

181-
except KeyError as e:
184+
except KeyError:
182185
pass
183186

184187
return packages

0 commit comments

Comments
 (0)