chore: type checking fl8

Author: antazoey

audius/cli/__init__.py

@@ -1,4 +1,4 @@
-from typing import Optional
+from typing import TYPE_CHECKING, Optional
 
 from cyclopts import App
 
@@ -10,7 +10,10 @@
 from audius.cli.users import users
 from audius.cli.utils import print
 from audius.client_factory import get_hosts
-from audius.types import PlayerType
+
+if TYPE_CHECKING:
+    from audius.types import PlayerType
+
 
 audius = App()
 audius.command(config)
@@ -31,7 +34,7 @@ def hosts():
 
 
 @audius.command
-def play(track_id: Optional[str] = None, player: Optional[PlayerType] = None):
+def play(track_id: Optional[str] = None, player: Optional["PlayerType"] = None):
     """
     Play something from Audius
     """

audius/cli/tracks.py

@@ -1,12 +1,14 @@
 from pathlib import Path
-from typing import Optional
+from typing import TYPE_CHECKING, Optional
 
 from cyclopts import App
 
 from audius.cli.utils import print
 from audius.const import DEFAULT_BUFFER_SIZE
 from audius.sdk import Audius
-from audius.types import PlayerType
+
+if TYPE_CHECKING:
+    from audius.types import PlayerType
 
 tracks = App(name="tracks", help="View and play tracks")
 
@@ -58,7 +60,7 @@ def search(query: str = ""):
 
 
 @tracks.command(name="play")
-def play_track(track_id: Optional[str] = None, player: Optional[PlayerType] = None):
+def play_track(track_id: Optional[str] = None, player: Optional["PlayerType"] = None):
     """
     Play a track
 

audius/player/__init__.py

@@ -3,11 +3,11 @@
 from audius.client import API
 from audius.exceptions import MissingPlayerError
 from audius.player.af import AFPlayer
-from audius.player.base import BasePlayer
 from audius.player.vlc import VLCPlayer
 from audius.types import PlayerType
 
 if TYPE_CHECKING:
+    from audius.player.base import BasePlayer
     from audius.sdk import Audius
 
 
@@ -18,7 +18,7 @@ def __init__(self, sdk: "Audius") -> None:
             PlayerType.AFPLAY: AFPlayer,
             PlayerType.VLC: VLCPlayer,
         }
-        self._player_map: dict[PlayerType, BasePlayer] = {}
+        self._player_map: dict[PlayerType, "BasePlayer"] = {}
 
     def play(self, url: str, player_type: Optional[PlayerType] = None):
         player = self.get_player(player_type=player_type)
@@ -28,7 +28,7 @@ def display_now_playing(self, track: dict, player_type: Optional[PlayerType] = N
         player = self.get_player(player_type=player_type)
         player.display_now_playing(track)
 
-    def get_player(self, player_type: Optional[PlayerType] = None) -> BasePlayer:
+    def get_player(self, player_type: Optional[PlayerType] = None) -> "BasePlayer":
         player_type = player_type or self.config.player
         if player_type is not None:
             if player_type not in self._player_classes:

audius/player/base.py

@@ -4,14 +4,14 @@
 import click
 
 from audius.client import API
-from audius.types import PlayerType
 
 if TYPE_CHECKING:
     from audius.sdk import Audius
+    from audius.types import PlayerType
 
 
 class BasePlayer(API):
-    def __init__(self, player_type: PlayerType, sdk: "Audius"):
+    def __init__(self, player_type: "PlayerType", sdk: "Audius"):
         self._type = player_type
         super().__init__(sdk)
 

audius/tracks.py

@@ -2,16 +2,19 @@
 from collections.abc import Iterable, Iterator
 from pathlib import Path
 from random import randint
-from typing import IO, Optional, Union
+from typing import IO, TYPE_CHECKING, Optional, Union
 
 import click
-from requests import Response
 from requests.exceptions import HTTPError
 from tqdm import tqdm  # type: ignore
 
 from audius.client import API
 from audius.exceptions import OutputPathError, TrackNotFoundError
-from audius.types import FileDestination, PlayerType
+
+if TYPE_CHECKING:
+    from requests import Response
+
+    from audius.types import FileDestination, PlayerType
 
 
 class DownloadProgressBar(tqdm):
@@ -22,8 +25,8 @@ def update_to(self, b=1, bsize=1, tsize=None):
 
 
 def _write_response(
-    output_paths: list[FileDestination],
-    response: Response,
+    output_paths: list["FileDestination"],
+    response: "Response",
     progress_bar: Optional[DownloadProgressBar] = None,
     chunk_size: int = 1,
 ):
@@ -53,9 +56,9 @@ def _write_response(
 
 
 def _validate_output_paths(
-    output_paths: Union[FileDestination, Iterable[FileDestination]],
-) -> list[FileDestination]:
-    output_path_ls: list[FileDestination]
+    output_paths: Union["FileDestination", Iterable["FileDestination"]],
+) -> list["FileDestination"]:
+    output_path_ls: list["FileDestination"]
     if not isinstance(output_paths, (list, tuple)):
         output_path_ls = [output_paths]  # type: ignore
     else:
@@ -88,7 +91,7 @@ def search(self, query: str = "") -> list[dict]:
         result = self.client.get("tracks/search", params={"query": query})
         return result.get("data", [])
 
-    def play(self, track_id: Optional[str], player: Optional[PlayerType] = None):
+    def play(self, track_id: Optional[str], player: Optional["PlayerType"] = None):
         if track_id is None:
             # Get a random track.
             result = self.search()
@@ -107,7 +110,7 @@ def play(self, track_id: Optional[str], player: Optional[PlayerType] = None):
     def download(
         self,
         track_id: str,
-        output_paths: Union[FileDestination, Iterable[FileDestination]],
+        output_paths: Union["FileDestination", Iterable["FileDestination"]],
         hide_output: bool = False,
         chunk_size: int = 1,
     ):

setup.cfg

@@ -1,2 +1,3 @@
 [flake8]
 max-line-length = 100
+ignore = E704,W503,PYD002,TC003,TC006

setup.py

@@ -12,6 +12,7 @@
         "types-requests",
         "types-setuptools",
         "flake8>=7.1.1",
+        "flake8-type-checking",
         "isort>=5.13.2",
         "mdformat>=0.7.21",
         "mdformat-gfm>=0.3.5",
@@ -58,7 +59,8 @@
     include_package_data=True,
     install_requires=[
         "requests>=2.32.3,<3",
-        "" "tqdm>=4.67.1,<5",
+        "cyclopts>=3.4.1,<4",
+        "tqdm>=4.67.1,<5",
         "afplay-py>=0.2.0,<0.3",
     ],
     python_requires=">=3.9,<4",