Switch to ruff

[Gobot1234]

The dev guide seems to recommend using ruff now it isn't suggesting black/isort and flake8.

I'd also like to suggest some slightly stricter rules to go along with the ones already suggested just based on what I personally find useful for type checked repos

select = ["C4", "F", "G", "I", "PTH", "RUF", "SIM", "TC", "UP", "W", "PERF"]
ignore = ["F402", "F403", "F405", "PERF203", "SIM105"]

Interested if anyone from the core team has other preferences @ansys/pyfluent-maintainers

[raph-luc]

@Gobot1234 This is a good suggestion, and also something we were considering for the Fluids One repositories. We definitely should consider this for PyFluent as well

Can you explain what are all those options you are suggesting, so that we don't have to look them up ourselves?

[Gobot1234]

C4 - https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4 (write comprehensions in their simplest forms)
F - https://docs.astral.sh/ruff/rules/#pyflakes-f (this is normal pyflakes)
G - https://docs.astral.sh/ruff/rules/#flake8-logging-format-g (check the formatting on logs is correct) It might also be useful to enable LOG codes as well
I - isort
PTH - https://docs.astral.sh/ruff/rules/#flake8-use-pathlib-pth (use pathlib in more places, there are a lot of join(os.getcwd(), "file") which could just be "file" which it won't catch)
RUF - https://docs.astral.sh/ruff/rules/#ruff-specific-rules-ruf (a bunch of custom rules that are all good in my book)
SIM - https://docs.astral.sh/ruff/rules/#flake8-simplify-sim (simplifies your code)
TC - https://docs.astral.sh/ruff/rules/#flake8-type-checking-tc (hygiene stuff for type checking not sure how important this is for this library as everything is already very heavy to import anyway)
UP - https://docs.astral.sh/ruff/rules/#pyupgrade-up (keeps your code using modern python idiosyncrasies)
W - https://docs.astral.sh/ruff/rules/#warning-w (some formatting nitpicks, mostly fixed by the formatter)
PERF - https://docs.astral.sh/ruff/rules/#perflint-perf (some marginal performance wins)

Ignored ones
F402 - import-shadowed-by-loop-var (I don't think this matters, typecheckers will warn you if you're doing something actually bad)
F403/5 - undefined-local-with-import-star (again type checkers are meant to deal with this)
PERF203 - try-except-in-loop (this code seems fine to me if you need it)
SIM105 suppressible-exception (I think the default case is simple enough)

[raph-luc]

Seems like a reasonable list to me, I think we will probably shamelessly steal that list and use it in other repos, haha.

Just regarding the ignores, I would vote for not adding those ignores, trying out the rules first and then if we are bothered by its suggestions, we add them to the ignore list

I imagine the first time we run this in the code, we will be able to tell which rules we should ignore or not