FEAT: Grpc transition #782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pyedb/grpc/edb_core/edb_data/edbvalue.py
github-actions
bot
added
documentation
|
@svandenb-dev I won't have the time to review the changes with my current work load. |
hui-zhou-a
reviewed
Jan 27, 2025
Comment on lines
+814
to
+833
| if plot_net and self.net_name: | ||
| fig, ax = self._pedb.nets.plot([self.net_name], color_by_net=True, show=False, show_legend=False) | ||
| else: | ||
| fig = plt.figure(figsize=figsize) | ||
| ax = fig.add_subplot(1, 1, 1) | ||
| xt, yt = self.points() | ||
| p1 = [(i, j) for i, j in zip(xt[::-1], yt[::-1])] | ||
|
|
||
| holes = [] | ||
| for void in self.voids: | ||
| xvt, yvt = void.points(arc_segments=3) | ||
| h1 = [(i, j) for i, j in zip(xvt, yvt)] | ||
| holes.append(h1) | ||
| poly = Polygon(p1, holes) | ||
| plot_polygon(poly, add_points=False, color=(1, 0, 0)) | ||
| ax.grid(False) | ||
| ax.set_axis_off() | ||
| # Hide axes ticks | ||
| ax.set_xticks([]) | ||
| ax.set_yticks([]) |
There was a problem hiding this comment.
ax is set in nets.plot() in line 815. Is it correct to set it again from 829 to 833?
@svandenb-dev is this PR ready for review? Some tests are failing. |
No it's not yet ready. I will remove the config file test for now and will work on fixing failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.