Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: read Spice model from file #899

Closed
wants to merge 3 commits into from
Closed

FIX: read Spice model from file #899

wants to merge 3 commits into from

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a linked an issue Nov 16, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies labels Nov 16, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't think we should be handling the encoding issue in pyedb. The problem being solved is that a file was written with an encoding that is incompatible with Linux. Is it something that we are creating and then can't read ourselves ? If that's the case, then we need to deal with it to ensure that a generated file can be read in the same space. However, if the file was written using Windows encoding, I would prefer users to perform the conversion to make it compatible with Linux (iconv -f "my-encoding" -t utf-8 origine_file reencoded_file).

Otherwise, we'll have to add a dependency that is not very used (could add security issues) and we would have to add this changes in every part of the code base where a file is open.

@hui-zhou-a hui-zhou-a marked this pull request as draft November 18, 2024 12:05
@aohta2021
Copy link

I can get successfule on Linux after changed to UTF-8 format of tcm0403s_350_2p_t210_s.mod( SPICE file).
The issue was SPICE format in Linux environment.
It have to changed to UTF-8 format.
This issue has been fixed.

Thank you.

@hui-zhou-a hui-zhou-a closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in assign_spice_model
3 participants