Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

Workaround to the fact that NAR operators are exposed as mapdl::rst::<operator-name> (e.g. mapdl::rst::NS) but the operator name in the result info only includes <operator-name> (e.g. NS). These changes allow to query the native location of say mapdl::rst::NS.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.12%. Comparing base (771f72b) to head (6e2a986).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   85.11%   85.12%   +0.01%     
==========================================
  Files          52       52              
  Lines        5220     5224       +4     
==========================================
+ Hits         4443     4447       +4     
  Misses        777      777              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedericoNegri FedericoNegri marked this pull request as ready for review November 13, 2025 13:31
@FedericoNegri FedericoNegri merged commit 684b917 into main Nov 13, 2025
73 of 74 checks passed
@FedericoNegri FedericoNegri deleted the fix/nar-location branch November 13, 2025 17:18
@PProfizi
Copy link
Contributor

PProfizi commented Nov 13, 2025

Hi @FedericoNegri just so I understand, why do we need to deal with mapdl::rst::NS in a specific way? Why not go through NS? When is mapdl::rst::NS called explicitly? Is it a workaround for your project?

@FedericoNegri
Copy link
Contributor Author

As in the description: those results report for example NS as operator name, but NS is not exposed, only mapdl::rst::NS is. So we use mapdl::rst::NS in result workflows, but would then fail to query the native location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants