Skip to content

Conversation

@Gobot1234
Copy link

Spoke a little to Jorge Martinez Garrido about this I think this is a reasonable selection of type checkers to support.

Users should pin the type checker themselves inside of their ci_types requirements

@Gobot1234 Gobot1234 requested a review from a team as a code owner November 20, 2025 13:48
@github-actions github-actions bot added the enhancement General improvements to existing features label Nov 20, 2025
@github-actions github-actions bot added the ci Pipelines maintenance related label Nov 25, 2025
@Gobot1234
Copy link
Author

Are the fails anything to be worried about?
I do also worry with the type checker tests they'll fail here if a downstream user of the test doesn't have theirs passing on their main branch no?

@jorgepiloto
Copy link
Member

Hi @Gobot1234, thanks for your time implementing this action. However, I don't think we should merge it. The reason is that we assume that code-style runs via pre-commit. This has two advantages:

  • It forces projects to use pre-commit if they want to use the code-style action
  • We delegate the linters and tools to the projects

Thus, despite your effort here, I'm suggesting to reject this contribution.

@Gobot1234
Copy link
Author

Gobot1234 commented Nov 26, 2025

@jorgepiloto, thank you for the thoughts. The reason I am opting for this over precommit is because it doesn't support annotating the changes e.g.
image
This makes it far easier to tell what's going wrong cause it's got context.

We also aren't using it for typical precommit because running a type checker on your whole codebase takes yonks and doing that for every commit slows down development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants