Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible updates? #162

Open
don20aba opened this issue May 3, 2023 · 3 comments
Open

Possible updates? #162

don20aba opened this issue May 3, 2023 · 3 comments

Comments

@don20aba
Copy link

don20aba commented May 3, 2023

Is there any newer, maintained script out there and what is everyone using for reading comics online lately?
I love this one, but can't seem to find updates anywhere.

@Owyn
Copy link

Owyn commented May 14, 2023

You could check fork network to see anyone working on this: https://github.com/anka-213/webcomic_reader/network

But no, I haven't found any :-(

@anka-213
Copy link
Owner

anka-213 commented May 15, 2023

i haven't used this script for quite a while so i haven't prioritized updating it, but if there's anything specific you want it updated for feel free to open issues (or even better, pull requests) and i can take a look when i have some spare time

@SoraHjort
Copy link

I do have an semi active dev branch that I've been working on some stuff, on and off for several years. It'll probably still be a while before I submit all the changes to this master. Largely focused on making it easier to use the script on smart phones, since that has been where I've been reading newly stumbled upon comics lately. As well as fixing/adding in some stuff. That branch makes it easier for me to test on mobile.

And the intent is to push those changes over to this repo in the future. Attention span willing, seems the rate I go is several times a year.

But again, it's a dev branch, and may have issues I've yet to see with the changes I make. For an example, I just found out today why multi-selector xpaths for navigation capture don't work on chromium browsers (and likely any other non-gecko based browsers), two lines that basically go "if not firefox then do this".

So several sites I've added in the past and into the dev branch don't properly work with finding next and previous links, since the xpath is trying to look through multiple possible entries that match the query, and it just errors out when not on firefox for those sites.

Removing the two lines seem to fix the issue. The problem is, I don't know why those two lines were put in, and I don't know the ramifications of simply removing them will do. Is there an issue with xpath evaluations that browsers do differently from firefox? is that issue even still there? After some more testing I'll probably push it later today, but the real test will be over several weeks of general use.

And yesterday, I pushed a change that solved an issue with using the border setting, where it would squish the image horizontally. I'm still testing to make sure it doesn't do anything strange. But so far it looks good.

Eitherway, while it is semi active, repeating again that it is just a dev branch. With full intent on bringing it into this main repo. I'm also not exactly taking requests for adding sites to it, since the main focus has been to get various tweaks, fixes, and changes in. But you are welcome to check it out.

I just have a terrible attention span that keeps me from getting to everything on my list of things to do in a timely manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants