require reject reasons #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrhappyma is attempting to deploy a commit to the anirudhb's projects Team on Vercel. A member of the Team first needs to authorize it. |
anirudhb
requested changes
Oct 18, 2024
Owner
anirudhb
left a comment
anirudhb
left a comment
There was a problem hiding this comment.
Can you rework this to add a "reject with reason" button instead? Requiring this for all confessions would greatly increase friction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've seen this discussed a couple times but never actually added so... here's a pr!
i'm willing to add stuff to help this not slow things down, if needed (list of template/canned reasons? reject multiple at a time?). or if y'all decides this is overall a bad idea overall feel free to close this.
shows a modal when rejecting, asking for a reason. reasons are posted in
CONFESSIONS_META_CHANNEL_ID(presumably #confessions-meta)