Provide console errors when routes cannot be evaluated

[krimple]

I'm trying to debug a simple multi-component view (top/bottom views) - for some reason when I used ng-link to compose the link it just returns the link to the page root. This happens any time the router can't figure out what I want.

I'm hoping we can get diagnostic errors when we construct something wrong. For example, if the component name is wrong (and the directory or js is missing), it'd help to report that. Or if the expression isn't a valid route, we should log that as well.

[krimple]

Here is a plunker to show the case. The actual #/one and #/two href links work, the ng-link ones just render links to the page.

http://plnkr.co/edit/VhtK8Nsh1iXSbDlKE6vm

Ken

[btford]

👍

On Tue, Mar 17, 2015 at 11:02 AM Ken Rimple notifications@github.com
wrote:

Here is a plunker to show the case. The actual #/one and #/two href links
work, the ng-link ones just render links to the page.

http://plnkr.co/edit/VhtK8Nsh1iXSbDlKE6vm

Ken

—
Reply to this email directly or view it on GitHub
#190 (comment).

[nicolashery]

+1

This definitely gave me a hard time debugging. My controller had an error in its constructor function, but I had no idea where or what...

I'm sure there was a reason for "silently" catching the error and replacing with an empty controller, but in my case I preferred for it to "fail hard" if the controller couldn't be created. So I ended up changing in $initControllersStep:

// from
var ctrl;
try {
  ctrl = $controller(controllerName, locals);
} catch(e) {
  console.warn && console.warn('Could not instantiate controller', controllerName);
  ctrl = $controller(angular.noop, locals);
}

// to
var ctrl = $controller(controllerName, locals);

[erindru]

Is there any progress on fixing this? It makes the new router extremely difficult to use.

Following along the lines of @nicolashery , I changed:

console.warn && console.warn('Could not instantiate controller', controllerName);

to:

console.warn && console.warn('Could not instantiate controller', controllerName, e);

so I could see the error, but id rather not modify the angular-new-router source code if I can avoid it