This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Proposal: change name of default comment insertion #111
Open
Description
When setting up a super simple scenario with the new router like this:
var app = angular.module('myApp', ['ngNewRouter']);
app.controller('AppController', function ($router) {
$router.config([
{
path: '/',
component: 'welcome'
}
]);
});
app.controller('WelcomeController', function () {
...
});And a template like this:
<body ng-app="myApp" ng-controller="AppController">
<router-view-port></router-view-port>
</body>There's no specified component name in the template which ends up in a compiled comment insertion like this:
Where undefined is prolly the value of either router-view-port="" or view-port-name="", which is undefined if there's no name given. However, the term undefined makes it look a bit broken to me (even if it actually isn't). So I wonder if we want to change that to something more declarative like default.
Wdyt?