build: change size to "medium" and "small"

There are several warnings about tests whose specified size is too big. These tests shards run under 300s and thus `medium` is more appropiate.

Author: alan-agius4

modules/testing/builder/src/builder-harness.ts

@@ -263,7 +263,7 @@ export class BuilderHarness<T> {
     }
 
     const logs: logging.LogEntry[] = [];
-    context.logger.subscribe((e) => logs.push(e));
+    const logger$ = context.logger.subscribe((e) => logs.push(e));
 
     return observableFrom(this.schemaRegistry.compile(this.builderInfo.optionSchema)).pipe(
       mergeMap((validator) => validator(targetOptions)),
@@ -302,6 +302,7 @@ export class BuilderHarness<T> {
       }),
       finalize(() => {
         this.watcherNotifier = undefined;
+        logger$.unsubscribe();
 
         for (const teardown of context.teardowns) {
           // eslint-disable-next-line @typescript-eslint/no-floating-promises

packages/angular/build/BUILD.bazel

@@ -291,23 +291,23 @@ ts_project(
 
 jasmine_test(
     name = "application_integration_tests",
-    size = "large",
+    size = "medium",
     data = [":application_integration_test_lib"],
     flaky = True,
-    shard_count = 20,
+    shard_count = 25,
 )
 
 jasmine_test(
     name = "dev-server_integration_tests",
-    size = "large",
+    size = "medium",
     data = [":dev-server_integration_test_lib"],
     flaky = True,
     shard_count = 10,
 )
 
 jasmine_test(
     name = "karma_integration_tests",
-    size = "large",
+    size = "medium",
     data = [":karma_integration_test_lib"],
     env = {
         # TODO: Replace Puppeteer downloaded browsers with Bazel-managed browsers,
@@ -320,9 +320,9 @@ jasmine_test(
 
 jasmine_test(
     name = "unit-test_integration_tests",
-    size = "large",
+    size = "small",
     data = [":unit-test_integration_test_lib"],
-    shard_count = 10,
+    shard_count = 5,
 )
 
 genrule(

packages/angular/build/src/builders/application/tests/options/polyfills_spec.ts

@@ -16,71 +16,73 @@ const testsVariants: [suitName: string, baseUrl: string | undefined][] = [
 ];
 
 describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
-  for (const [suitName, baseUrl] of testsVariants) {
-    describe(suitName, () => {
-      beforeEach(async () => {
-        await harness.modifyFile('tsconfig.json', (content) => {
-          const tsconfig = JSON.parse(content);
-          tsconfig.compilerOptions.baseUrl = baseUrl;
-
-          return JSON.stringify(tsconfig);
-        });
-      });
-
-      it('uses a provided TypeScript file', async () => {
-        harness.useTarget('build', {
-          ...BASE_OPTIONS,
-          polyfills: ['src/polyfills.ts'],
+  describe('Option: polyfills', () => {
+    for (const [suitName, baseUrl] of testsVariants) {
+      describe(suitName, () => {
+        beforeEach(async () => {
+          await harness.modifyFile('tsconfig.json', (content) => {
+            const tsconfig = JSON.parse(content);
+            tsconfig.compilerOptions.baseUrl = baseUrl;
+
+            return JSON.stringify(tsconfig);
+          });
         });
 
-        const { result } = await harness.executeOnce();
+        it('uses a provided TypeScript file', async () => {
+          harness.useTarget('build', {
+            ...BASE_OPTIONS,
+            polyfills: ['src/polyfills.ts'],
+          });
 
-        expect(result?.success).toBe(true);
-
-        harness.expectFile('dist/browser/polyfills.js').toExist();
-      });
+          const { result } = await harness.executeOnce();
 
-      it('uses a provided JavaScript file', async () => {
-        await harness.writeFile('src/polyfills.js', `console.log('main');`);
+          expect(result?.success).toBe(true);
 
-        harness.useTarget('build', {
-          ...BASE_OPTIONS,
-          polyfills: ['src/polyfills.js'],
+          harness.expectFile('dist/browser/polyfills.js').toExist();
         });
 
-        const { result } = await harness.executeOnce();
+        it('uses a provided JavaScript file', async () => {
+          await harness.writeFile('src/polyfills.js', `console.log('main');`);
 
-        expect(result?.success).toBe(true);
+          harness.useTarget('build', {
+            ...BASE_OPTIONS,
+            polyfills: ['src/polyfills.js'],
+          });
 
-        harness.expectFile('dist/browser/polyfills.js').content.toContain(`console.log("main")`);
-      });
+          const { result } = await harness.executeOnce();
+
+          expect(result?.success).toBe(true);
 
-      it('fails and shows an error when file does not exist', async () => {
-        harness.useTarget('build', {
-          ...BASE_OPTIONS,
-          polyfills: ['src/missing.ts'],
+          harness.expectFile('dist/browser/polyfills.js').content.toContain(`console.log("main")`);
         });
 
-        const { result, logs } = await harness.executeOnce({ outputLogsOnFailure: false });
+        it('fails and shows an error when file does not exist', async () => {
+          harness.useTarget('build', {
+            ...BASE_OPTIONS,
+            polyfills: ['src/missing.ts'],
+          });
 
-        expect(result?.success).toBe(false);
-        expect(logs).toContain(
-          jasmine.objectContaining({ message: jasmine.stringMatching('Could not resolve') }),
-        );
+          const { result, logs } = await harness.executeOnce({ outputLogsOnFailure: false });
 
-        harness.expectFile('dist/browser/polyfills.js').toNotExist();
-      });
+          expect(result?.success).toBe(false);
+          expect(logs).toContain(
+            jasmine.objectContaining({ message: jasmine.stringMatching('Could not resolve') }),
+          );
 
-      it('resolves module specifiers in array', async () => {
-        harness.useTarget('build', {
-          ...BASE_OPTIONS,
-          polyfills: ['zone.js', 'zone.js/testing'],
+          harness.expectFile('dist/browser/polyfills.js').toNotExist();
         });
 
-        const { result } = await harness.executeOnce();
-        expect(result?.success).toBeTrue();
-        harness.expectFile('dist/browser/polyfills.js').toExist();
+        it('resolves module specifiers in array', async () => {
+          harness.useTarget('build', {
+            ...BASE_OPTIONS,
+            polyfills: ['zone.js', 'zone.js/testing'],
+          });
+
+          const { result } = await harness.executeOnce();
+          expect(result?.success).toBeTrue();
+          harness.expectFile('dist/browser/polyfills.js').toExist();
+        });
       });
-    });
-  }
+    }
+  });
 });