fix: pipe on startWithUndefined for undefined input

nartc · nartc · commit 96fd6e09a3af · 2023-01-30T22:39:07.000-06:00
diff --git a/libs/angular-three-postprocessing/package.json b/libs/angular-three-postprocessing/package.json
@@ -24,6 +24,7 @@
     "peerDependencies": {
         "@angular/common": "^15.1.0",
         "@angular/core": "^15.1.0",
+        "angular-three": "^1.0.0",
         "postprocessing": "^6.0.0"
     },
     "dependencies": {
diff --git a/libs/angular-three-postprocessing/src/lib/effect.ts b/libs/angular-three-postprocessing/src/lib/effect.ts
@@ -75,7 +75,7 @@ export function componentInputsToCombinedStream(
     return combineLatest(
         inputs.reduce((combined, input) => {
             let input$ = component.select(input);
-            if (component.get(input) !== undefined) {
+            if (component.get(input) === undefined) {
                 input$ = input$.pipe(startWithUndefined());
             }
             combined[input] = input$;

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export function componentInputsToCombinedStream(`
`75`	`75`	`return combineLatest(`
`76`	`76`	`inputs.reduce((combined, input) => {`
`77`	`77`	`let input$ = component.select(input);`
`78`		`- if (component.get(input) !== undefined) {`
	`78`	`+ if (component.get(input) === undefined) {`
`79`	`79`	`input$ = input$.pipe(startWithUndefined());`
`80`	`80`	`}`
`81`	`81`	`combined[input] = input$;`