Fix ALPHA_8 format support for bitmap in Cue. #2058
+66
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
peerless2012
changed the title
icbaker
reviewed
Jan 27, 2025
| @@ -835,6 +837,9 @@ public Cue build() { | |||
| private static final String FIELD_MULTI_ROW_ALIGNMENT = Util.intToStringMaxRadix(2); | |||
| private static final String FIELD_BITMAP_PARCELABLE = Util.intToStringMaxRadix(3); | |||
| private static final String FIELD_BITMAP_BYTES = Util.intToStringMaxRadix(18); | |||
| private static final String FIELD_BITMAP_ORIGIN_WIDTH = Util.intToStringMaxRadix(19); | |||
There was a problem hiding this comment.
what is the meaning of the word 'origin' here?
|
|
||
| /** Tests for {@link Cue}. */ | ||
| @RunWith(AndroidJUnit4.class) | ||
| public class CueTest { |
There was a problem hiding this comment.
let's just move the whole of CueTest to androidTest instead of splitting it like this.
| bitmap = Bitmap.createBitmap(bitmapWidth,bitmapHeight, Bitmap.Config.ALPHA_8); | ||
| Buffer buffer = ByteBuffer.wrap(bitmapBytes); | ||
| bitmap.copyPixelsFromBuffer(buffer); | ||
| builder.setBitmap(bitmap); |
There was a problem hiding this comment.
optional: de-duplicate the 3 builder.setBitmap lines, so the code is instead:
@Nullable Bitmap bitmap = bundle.getParcelable(FIELD_BITMAP_PARCELABLE);
if (bitmap == null) {
// handle bytes case (both compressed and uncompressed) with
// existing code, but assigning `bitmap` each time instead of setting
// it on the builder.
}
builder.setBitmap(bitmap); // Passing null is fine here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitmap.compress not support ALPHA_8 format, so we just copy the pixel buffer.
This should fix #2054