Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check for ocamlformat #182

Open
naartjie opened this issue Dec 4, 2019 · 4 comments
Open

Add CI check for ocamlformat #182

naartjie opened this issue Dec 4, 2019 · 4 comments

Comments

@naartjie
Copy link
Contributor

naartjie commented Dec 4, 2019

Ocamlformat has been added to the project via #177.

I'm opening up this issue to track the fact that we still need to add a CI check for it.

I had an initial look at it, but to be honest I don't really know how TravisCI works, nor the ocaml build pipeline in travis. If anyone has any suggestions or tips, please comment here, thanks.

@andreas
Copy link
Owner

andreas commented Dec 4, 2019

If it makes a difference, I'd be perfectly happy with a different CI setup also (Travis is very slow!), e.g. based on Github Actions, CircleCI or similar.

@wokalski
Copy link

wokalski commented Dec 4, 2019

here's a validation workflow from brisk-reconciler

https://github.com/briskml/brisk-reconciler/blob/d185e75c47b381fb911ca9decdf7525b97188ea1/.github/workflows/validate-pr.yml

@naartjie
Copy link
Contributor Author

naartjie commented Dec 5, 2019

Great idea. GitHub actions sounds perfect for this.

@wokalski
Copy link

wokalski commented Dec 5, 2019

It even posts a comment when linter has spotted an issue. Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants