move channel implementations to details namespace

Author: anderspkd

include/scl/net/loopback.h

@@ -24,7 +24,7 @@
 #include "scl/coro/task.h"
 #include "scl/net/channel.h"
 
-namespace scl {
+namespace scl::details {
 
 /**
  * @brief A loopback channel.

include/scl/net/tcp/channel.h

@@ -19,7 +19,7 @@
 
 #include "scl/net/channel.h"
 
-namespace scl {
+namespace scl::details {
 
 /**
  * @brief A channel implementation using TCP.

src/scl/net/tcp/channel.cc

@@ -23,7 +23,7 @@
 
 using namespace scl;
 
-void TcpChannel::close() {
+void details::TcpChannel::close() {
   if (m_alive) {
     // ensures that we only attempt to close the socket once, even if closing
     // the somehow socket fails.
@@ -37,11 +37,11 @@ void TcpChannel::close() {
   }
 }
 
-Task<void> TcpChannel::send(Packet&& packet) {
+Task<void> details::TcpChannel::send(Packet&& packet) {
   co_await send(packet);
 }
 
-Task<void> TcpChannel::send(const Packet& packet) {
+Task<void> details::TcpChannel::send(const Packet& packet) {
   // Write the packet size to a buffer.
   const Packet::SizeType pkt_sz = packet.dataSize();
   const auto pkt_t_sz = sizeof(Packet::SizeType);
@@ -126,7 +126,7 @@ Task<bool> recvInto(int socket,
 
 }  // namespace
 
-Task<Packet> TcpChannel::recv() {
+Task<Packet> details::TcpChannel::recv() {
   unsigned char packet_size_buf[sizeof(Packet::SizeType)] = {0};
 
   // read size of the packet.
@@ -141,7 +141,7 @@ Task<Packet> TcpChannel::recv() {
   co_return packet;
 }
 
-Task<std::optional<Packet>> TcpChannel::recv(Time::Duration timeout) {
+Task<std::optional<Packet>> details::TcpChannel::recv(Time::Duration timeout) {
   unsigned char packet_size_buf[sizeof(Packet::SizeType)] = {0};
 
   // attempt to read the size of the packet. If we timeout here, we will simply
@@ -167,6 +167,6 @@ Task<std::optional<Packet>> TcpChannel::recv(Time::Duration timeout) {
   co_return packet;
 }
 
-Task<bool> TcpChannel::poll() {
+Task<bool> details::TcpChannel::poll() {
   co_return details::pollSocket(m_socket, POLLIN);
 }

src/scl/net/tcp/network.cc

@@ -148,7 +148,7 @@ Task<Network> scl::createTcpNetwork(const NetworkConfig& config) {
   const std::size_t id = config.id();
   const std::size_t n = config.networkSize();
 
-  channels[id] = LoopbackChannel::create();
+  channels[id] = details::LoopbackChannel::create();
 
   std::vector<Task<SocketAndId>> tasks;
 
@@ -168,7 +168,7 @@ Task<Network> scl::createTcpNetwork(const NetworkConfig& config) {
   details::sys_call::close(server_socket);
 
   for (const SocketAndId& sai : sais) {
-    channels[sai.id] = std::make_shared<TcpChannel>(sai.socket);
+    channels[sai.id] = std::make_shared<details::TcpChannel>(sai.socket);
   }
 
   co_return Network{channels, config.id()};

src/scl/simulation/simulator.cc

@@ -144,7 +144,7 @@ std::vector<std::shared_ptr<Channel>> createChannels(
 
   for (std::size_t remote_pid = 0; remote_pid < n; remote_pid++) {
     if (remote_pid == local_pid) {
-      channels.emplace_back(LoopbackChannel::create());
+      channels.emplace_back(details::LoopbackChannel::create());
     } else {
       ChannelId id(local_pid, remote_pid);
       channels.emplace_back(

test/scl/net/test_loopback.cc

@@ -25,7 +25,7 @@
 using namespace scl;
 
 TEST_CASE("Loopback to self close", "[net]") {
-  auto channel = LoopbackChannel::create();
+  auto channel = details::LoopbackChannel::create();
 
   Packet p;
   p << 1 << 2 << 3;
@@ -41,7 +41,7 @@ TEST_CASE("Loopback to self close", "[net]") {
 }
 
 TEST_CASE("Loopback send/recv", "[net]") {
-  auto channels = LoopbackChannel::createPaired();
+  auto channels = details::LoopbackChannel::createPaired();
   auto chl0 = channels[0];
   auto chl1 = channels[1];