Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Latest branch bugs out the stop button #220

Closed
3 of 6 tasks
Dajova opened this issue Mar 8, 2024 · 3 comments
Closed
3 of 6 tasks

[Bug]: Latest branch bugs out the stop button #220

Dajova opened this issue Mar 8, 2024 · 3 comments

Comments

@Dajova
Copy link

Dajova commented Mar 8, 2024

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

fafb0b5
This branch makes the stop button for generations unusable. No matter what model i use, it doesnt stop the generation, even tho the UI indicates that it's stopped. And the only way to stop it is to close the console window itself.

Steps to reproduce the problem

  • update to latest branch.
  • start generating anything.
  • stop the generation.
  • keeps on generating.

What should have happened?

Should just stop generating the current batch.

What browsers do you use to access the UI ?

Firefox.

Sysinfo

Console logs

-

Additional information

No response

@anapnoe
Copy link
Owner

anapnoe commented Mar 9, 2024

please test also with chrome browser
it should work on firefox if you Go to the Firefox about:config page, then search and toggle layout. css.has-selector. enabled

@Dajova
Copy link
Author

Dajova commented Mar 9, 2024

Did. tested firefox, chrome and edge, neither was able to stop the generation once it started. All browsers indicated that the generation was stopped in the UI, but kept on generating regardless.

edit: i think i may have found the culprit, but it started happening with that commit regardless, so it seems like a incompatibility issue.
https://github.com/ilian6806/stable-diffusion-webui-state is the extension.

edit2: Nwm, I hard-resetted/reinstalled the latest commit and it was still doing it, even after disabling that extension. Something is clearly wrong in the build.

edit3: Ok.., now it only triggers with the WebUI State extension again after i've applied latest 5 major commits again. I have no idea what's going on at this point.

edit4: Nwm again, now it just seems to stop working randomly. One batch was working fine and then the next one, it stops working again. It's infuriating.

@Dajova Dajova changed the title [Bug]: Latest branch bugs out the stop button [Bug]: Latest branch bugs out the stop button when using WebUI State extension. Mar 10, 2024
@Dajova Dajova changed the title [Bug]: Latest branch bugs out the stop button when using WebUI State extension. [Bug]: Latest branch bugs out the stop button Mar 11, 2024
@Dajova
Copy link
Author

Dajova commented Mar 13, 2024

Ok, it seems this wasn't a bug after all, it was just a new option that was undocumented and enabled by default. Disabling this and it's fine again.
image

@Dajova Dajova closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants