Ip check #16
Ip check #16
Conversation
| IPv4: bool = True, | ||
| IPv6: bool = True): |
There was a problem hiding this comment.
Why are these here instead of in attributes? Seems like you should set these in ResourceAttributes. Not in initialize_telemetry.
There was a problem hiding this comment.
I put them there to go along with collect_IP, but putting them in ResourceAttributes is probably cleaner considering that in most cases both of these values would be untouched
There was a problem hiding this comment.
Plus, doesn't the attr class actually do the retrieval work?
There was a problem hiding this comment.
technically no, it's a function defined in the attributes class but its called by initialize_telemetry. I will think about this though. I might be able to evaluate IP data before telemetry even gets initialized which would solve the blocking problem
No description provided.