events: do not derive Default on event sections

It is not required by the core or by any other piece of infrastructure.
Only some events need to derive from Default because of the way they are
constructed.

Signed-off-by: Adrian Moreno <[email protected]>

Author: amorenoz

retis-derive/src/lib.rs

@@ -26,7 +26,6 @@ pub fn event_section(
     let id: syn::Expr = syn::parse(args).expect("Invalid event id");
 
     let output = quote! {
-        #[derive(Default)]
         #[crate::event_type]
         #input
 

retis-events/src/common.rs

@@ -34,6 +34,7 @@ pub struct TaskEvent {
 
 /// Common event section.
 #[event_section(SectionId::Common)]
+#[derive(Default)]
 pub struct CommonEvent {
     /// Timestamp of when the event was generated.
     pub timestamp: u64,

retis-events/src/kernel.rs

@@ -4,6 +4,7 @@ use super::*;
 use crate::{event_section, event_type, Formatter};
 
 #[event_section(SectionId::Kernel)]
+#[derive(Default)]
 pub struct KernelEvent {
     /// Kernel symbol name associated with the event (i.e. which probe generated
     /// the event).

retis-events/src/nft.rs

@@ -5,6 +5,7 @@ use crate::{event_section, Formatter};
 
 /// Nft event section
 #[event_section(SectionId::Nft)]
+#[derive(Default)]
 pub struct NftEvent {
     pub table_name: String,
     pub chain_name: String,

retis-events/src/ovs.rs

@@ -7,8 +7,8 @@ use super::*;
 use crate::{event_section, event_type, Formatter};
 
 ///The OVS Event
-#[derive(PartialEq)]
 #[event_section(SectionId::Ovs)]
+#[derive(Default, PartialEq)]
 pub struct OvsEvent {
     /// Event data
     #[serde(flatten)]

retis-events/src/skb.rs

@@ -8,6 +8,7 @@ use crate::{event_section, event_type, Formatter};
 
 /// Skb event section.
 #[event_section(SectionId::Skb)]
+#[derive(Default)]
 pub struct SkbEvent {
     /// Ethernet fields, if any.
     pub eth: Option<SkbEthEvent>,

retis-events/src/skb_tracking.rs

@@ -14,8 +14,8 @@ use crate::{event_section, Formatter};
 ///
 /// Tl;dr; the tracking unique id is `(timestamp, orig_head)` and `skb` can be
 /// used to distinguished between clones.
-#[derive(Copy, PartialEq)]
 #[event_section(SectionId::SkbTracking)]
+#[derive(Default, Copy, PartialEq)]
 #[repr(C)]
 pub struct SkbTrackingEvent {
     /// Head of buffer (`skb->head`) when the packet was first seen by the

retis/src/collect/collector.rs

@@ -612,6 +612,7 @@ mod tests {
     }
 
     #[event_section(SectionId::Common)]
+    #[derive(Default)]
     struct TestEvent {}
 
     impl EventFmt for TestEvent {

retis/src/core/events/bpf.rs

@@ -644,6 +644,7 @@ mod tests {
     const DATA_TYPE_U128: u8 = 2;
 
     #[event_section(SectionId::Common)]
+    #[derive(Default)]
     struct TestEvent {
         field0: Option<u64>,
         field1: Option<u64>,