New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix serialiser #107

Closed

kennedymwavu opened this issue Feb 24, 2025 · 0 comments · Fixed by #108

Assignees

Labels

bug

Contributor

kennedymwavu commented Feb 24, 2025

following #100, i just noticed two issues with the new version of the serialiser:

since initially when using jsonlite::toJSON() we we're auto-unboxing atomic vectors of length 1, i suppose we should do the same for yyjsonr::write_json_str() (unless the user specifies otherwise).
we aren't passing the ... from res$json() to the serialiser. (bug)

The text was updated successfully, but these errors were encountered:

kennedymwavu self-assigned this

kennedymwavu added the bug label

kennedymwavu mentioned this issue

fix serialiser #108

Merged

kennedymwavu linked a pull request

that will close this issue

fix serialiser #108

Merged

JohnCoene closed this as completed in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment