Symptom
zz-tests_bats/previous_versions/v14/ceiling_directories.bats still uses the pre-git-semantics ceiling assumption that was fixed in current_version/ceiling_directories.bats by commit 8c41c62 (sets DODDER_CEILING_DIRECTORIES="$BATS_TEST_TMPDIR" and expects discovery AT $BATS_TEST_TMPDIR to be blocked, which it no longer is under git semantics).
Why it's latent today
The v14 snapshot is not run by the migration lane (previous_versions/main.bats only runs the 3 migration-validation tests migration_status_empty, migration_validate_schwanzen, migration_validate_history, migration_reindex). So the stale file isn't executed.
Risk
If a future per-version migration test lane is wired up that runs the snapshot's own ceiling_directories.bats, it will fail with the same bug pattern that the current_version version had before the 8c41c62 fix.
Fix options
- Update: mirror the current_version fix into v14 (
DODDER_CEILING_DIRECTORIES="$BATS_TEST_TMPDIR/child" so the walk actually stops short of the fixture's .dodder/).
- Delete: the snapshot's tests aren't exercised by anything; remove the file.
Either is acceptable; the choice is "preserve the frozen snapshot for parity" vs "delete unused code." Lean toward delete since previous_versions/v14/ is supposed to be a frozen-data snapshot, not a frozen-test snapshot.
—
Captured by Clown — https://github.com/amarbel-llc/clown :clown:
Symptom
zz-tests_bats/previous_versions/v14/ceiling_directories.batsstill uses the pre-git-semantics ceiling assumption that was fixed incurrent_version/ceiling_directories.batsby commit 8c41c62 (setsDODDER_CEILING_DIRECTORIES="$BATS_TEST_TMPDIR"and expects discovery AT$BATS_TEST_TMPDIRto be blocked, which it no longer is under git semantics).Why it's latent today
The v14 snapshot is not run by the migration lane (
previous_versions/main.batsonly runs the 3 migration-validation testsmigration_status_empty,migration_validate_schwanzen,migration_validate_history,migration_reindex). So the stale file isn't executed.Risk
If a future per-version migration test lane is wired up that runs the snapshot's own
ceiling_directories.bats, it will fail with the same bug pattern that the current_version version had before the 8c41c62 fix.Fix options
DODDER_CEILING_DIRECTORIES="$BATS_TEST_TMPDIR/child"so the walk actually stops short of the fixture's.dodder/).Either is acceptable; the choice is "preserve the frozen snapshot for parity" vs "delete unused code." Lean toward delete since
previous_versions/v14/is supposed to be a frozen-data snapshot, not a frozen-test snapshot.—
Captured by Clown — https://github.com/amarbel-llc/clown :clown: